Router redirect fix #3014
Merged
Router redirect fix #3014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when loading an app (Discover, Visualize, Dashboard) with an invalid saved object, the controller was still being called, and the
$destroyhandler was then trying to call undefined.The issue was that
courier.redirectWhenMissingwas resolving, and the controller was called before the redirect happened ($locationis async).The solution was the make
courier.redirectWhenMissingnever resolve, which was accomplished via a newPromise.halt()method. As an aside, this new Promise method should not have the same memory leak issues that all the other uses of unresolved promises have...