Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to enable frozen index search #27297

Merged
merged 4 commits into from
Dec 17, 2018

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Dec 17, 2018

Summary

Closes #26244, this adds an "Include frozen indices" setting, which will enable the ignore_throttled=false setting in all Kibana core querying infrastructures (Graph, Courier, TSVB, Timelion).

This PR doesn't change any behavior around solutions (like ML, APM). If those want to implement that behavior, ideally just read out the same setting to check whether that query parameter needs to be set.

Release Summary: Kibana now offers an advanced setting (search.includeFrozen) which allows to also query frozen indices during search.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@timroes timroes added Feature:Search Querying infrastructure in Kibana Feature:Timelion Timelion app and visualization Feature:TSVB TSVB (Time Series Visual Builder) v7.0.0 Feature:Graph Graph application feature Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.6.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages labels Dec 17, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested Chrome OSX; can verify ignore_throttled is being set as expected for visualizations & timelion. Docs look good too.

@timroes timroes merged commit 8964523 into elastic:master Dec 17, 2018
@timroes timroes deleted the frozen-indices-kibana branch December 17, 2018 21:21
timroes added a commit to timroes/kibana that referenced this pull request Dec 17, 2018
* Add setting to enable frozen index search

* Add description to docs

* Fix method calls
timroes added a commit that referenced this pull request Dec 17, 2018
* Add setting to enable frozen index search

* Add description to docs

* Fix method calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Graph Graph application feature Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Feature:Search Querying infrastructure in Kibana Feature:Timelion Timelion app and visualization Feature:TSVB TSVB (Time Series Visual Builder) release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.6.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants