-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting to enable frozen index search #27297
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
added
Feature:Search
Querying infrastructure in Kibana
Feature:Timelion
Timelion app and visualization
Feature:TSVB
TSVB (Time Series Visual Builder)
v7.0.0
Feature:Graph
Graph application feature
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v6.6.0
Feature:Kibana Management
Feature label for Data Views, Advanced Setting, Saved Object management pages
labels
Dec 17, 2018
Pinging @elastic/kibana-app |
7 tasks
💔 Build Failed |
💚 Build Succeeded |
lukeelmers
approved these changes
Dec 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested Chrome OSX; can verify ignore_throttled
is being set as expected for visualizations & timelion. Docs look good too.
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Dec 17, 2018
* Add setting to enable frozen index search * Add description to docs * Fix method calls
timroes
added a commit
that referenced
this pull request
Dec 17, 2018
This was referenced Jan 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Graph
Graph application feature
Feature:Kibana Management
Feature label for Data Views, Advanced Setting, Saved Object management pages
Feature:Search
Querying infrastructure in Kibana
Feature:Timelion
Timelion app and visualization
Feature:TSVB
TSVB (Time Series Visual Builder)
release_note:enhancement
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v6.6.0
v7.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #26244, this adds an "Include frozen indices" setting, which will enable the
ignore_throttled=false
setting in all Kibana core querying infrastructures (Graph, Courier, TSVB, Timelion).This PR doesn't change any behavior around solutions (like ML, APM). If those want to implement that behavior, ideally just read out the same setting to check whether that query parameter needs to be set.
Release Summary: Kibana now offers an advanced setting (
search.includeFrozen
) which allows to also query frozen indices during search.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately