Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: K7 breadcrumbs in Canvas #26669

Merged
merged 3 commits into from
Dec 4, 2018
Merged

Conversation

w33ble
Copy link
Contributor

@w33ble w33ble commented Dec 4, 2018

Summary

Closes #25896

Adds K7 breadcrumbs to Canvas, particularly for the "home" and "workpad" sections of the app. It also adds a simple redux middleware to keep the workpad name in the breadcrumb in sync with the input in the interface.

dec-04-2018 15-37-28

@w33ble w33ble added review v7.0.0 Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Dec 4, 2018
@w33ble w33ble requested a review from spalger December 4, 2018 22:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@spalger spalger requested a review from cchaos December 4, 2018 22:49
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@w33ble w33ble merged commit cc8fd17 into elastic:master Dec 4, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants