Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[I18n] Remove JSON5 dependency from kbn-i18n #26634

Merged
merged 1 commit into from
Dec 5, 2018
Merged

[I18n] Remove JSON5 dependency from kbn-i18n #26634

merged 1 commit into from
Dec 5, 2018

Conversation

LeanidShutau
Copy link
Contributor

Since we don't plan to use JSON5 in near future, it should be removed from kbn-i18n and replaced by default JSON.

@LeanidShutau LeanidShutau added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Project:i18n v6.6.0 labels Dec 4, 2018
@LeanidShutau LeanidShutau self-assigned this Dec 4, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

azasypkin
azasypkin approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally - works as expected.

maryia-lapata
maryia-lapata approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as expected

@LeanidShutau LeanidShutau added review and removed review labels Dec 5, 2018
@LeanidShutau LeanidShutau removed the request for review from pavel06081991 December 5, 2018 07:42
@LeanidShutau LeanidShutau merged commit c50e641 into elastic:master Dec 5, 2018
@LeanidShutau LeanidShutau deleted the feature/i18n-remove-json5-dependency branch December 5, 2018 07:48
LeanidShutau added a commit to LeanidShutau/kibana that referenced this pull request Dec 5, 2018
@LeanidShutau
[I18n] Remove JSON5 dependency from kbn-i18n (elastic#26634)
5af023b
@LeanidShutau LeanidShutau mentioned this pull request Dec 5, 2018
Merged
LeanidShutau added a commit that referenced this pull request Dec 5, 2018
@LeanidShutau
[I18n] Remove JSON5 dependency from kbn-i18n (#26634) (#26681)
3550fe0
@LeanidShutau
Copy link
Contributor Author

6.x/6.6: 3550fe0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azasypkin azasypkin azasypkin approved these changes

@maryia-lapata maryia-lapata maryia-lapata approved these changes

Assignees

@LeanidShutau LeanidShutau

Labels
backported Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LeanidShutau @elasticmachine @azasypkin @maryia-lapata