Adds clear function #26397
Merged
Adds clear function #26397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqliu1
added
review
v7.0.0
Team:Presentation
|
Pinging @elastic/kibana-canvas |
💚 Build Succeeded |
rashidkpc
suggested changes
Nov 30, 2018
| */ | ||
|
|
||
| export const clear = () => ({ | ||
| name: 'clear', |
There was a problem hiding this comment.
Add type: 'null' in here.
cqliu1
force-pushed
the
canvas/clear-function
branch
from
68674b3
to
929ac5f
Compare
|
@rashidkpc I added the return type to the clear function def. Good to merge? |
💚 Build Succeeded |
|
Do it
…On Mon, Dec 3, 2018 at 17:43 Elastic Machine ***@***.***> wrote:
💚 Build Succeeded
- continuous-integration/kibana-ci/pull-request
<https://kibana-ci.elastic.co/job/elastic+kibana+pull-request/2177/>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26397 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABMUUwB58aTCmFQf8xP9pdejBMnpRizZks5u1cUfgaJpZM4Y5Gmx>
.
|
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Dec 4, 2018
* Added clear function that returns null context * Added return type to clear function
cqliu1
added a commit
that referenced
this pull request
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25807.
This adds a Canvas function that doesn't take any args and returns
nullfor any context. This is especially helpful when you want to clear context before executing a function.