Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] Translate Query_bar #26264

Merged
merged 57 commits into from
Dec 5, 2018
Merged

[i18n] Translate Query_bar #26264

merged 57 commits into from
Dec 5, 2018

Conversation

Nox911
Copy link
Contributor

@Nox911 Nox911 commented Nov 27, 2018

Translate src -> ui -> public -> query_bar

@Nox911
Merge pull request #1 from elastic/master
c7ec189 
update
@Nox911
Merge pull request #2 from elastic/master
fa01b88 
second merge
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
70f6c7e
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
68587a0
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
42aa7d3
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
efeaefe
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
8a054ed
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
b0d1660
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
62b6ad1
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
acbad4b
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
a850650
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
0a200ce
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
b2a8244
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
b4b979e
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
d349a4f
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
ae285b9
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
3051641
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
6231971
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
f86a3d4
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
cf813c7
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
1aba03f
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
491009b
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
e243126
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
e74bd61
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
8bc5ffa
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
5787937
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
f17fa1e
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
c63b0a6
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
ed62b5b
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
df4fab4
@Nox911
Copy link
Contributor Author

Nox911 commented Dec 2, 2018

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@Nox911
Copy link
Contributor Author

Nox911 commented Dec 3, 2018

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes timroes added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Dec 3, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@timroes timroes self-requested a review December 3, 2018 14:12
@Nox911 Nox911 force-pushed the feature/translate-query_bar branch from 2e9f16e to 9246e8a Compare December 4, 2018 15:13
timroes
timroes approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Nox911 Nox911 merged commit 84adc1a into elastic:master Dec 5, 2018
@Nox911 Nox911 deleted the feature/translate-query_bar branch December 5, 2018 08:03
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Dec 6, 2018
@Nox911 @maryia-lapata
[i18n] Translate Query_bar (elastic#26264)
37761f4 
* Translate ui -> query_bar

* Fix id names

* Update snapshots

* Fix tests

* Add intl to props interface

* Fix test

* Fix tests

* Fix tests

* Fix test

* Fix tests
@maryia-lapata maryia-lapata mentioned this pull request Dec 6, 2018
Merged
Nox911 pushed a commit that referenced this pull request Dec 6, 2018
@maryia-lapata @Nox911
[i18n] Translate Query_bar (#26264) (#26756)
776eacd 
* Translate ui -> query_bar

* Fix id names

* Update snapshots

* Fix tests

* Add intl to props interface

* Fix test

* Fix tests

* Fix tests

* Fix test

* Fix tests
@Nox911 Nox911 added backported and removed review labels Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

@pavel06081991 pavel06081991 pavel06081991 approved these changes

Assignees
No one assigned
Labels
backported Project:i18n Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Nox911 @elasticmachine @pavel06081991 @timroes @maryia-lapata