[k7/Infra UI] Integrate with K7 Breadcrumbs

[weltenwort]

This PR changes the header to be conditionally rendered based on the k7design UI setting. If the setting is false, the header is rendered as before. If it is true, the header is hidden and the breadcrumbs are set via the Kibana breadcrumbs api.

Notes

• This currently loses the "BETA" badge since we don't control the K7 header anymore.
• It doesn't yet access the breadcrumbs on the chrome object, because [chrome/breadcrumbs] migrate to the new platform #25914 is not yet merged.

Testing

• Ensure the k7design UI settings is disabled.
• Check that the old header is rendered.
• Enable the k7design UI setting.
• Check that the K7 Header with correct breadcrumbs is rendered on the home page, the node detail page and the log page.

Related Issues

• meta issue [k7] Make breadcrumbs more consistent #25884
• new platform breadcrumb refactoring [chrome/breadcrumbs] migrate to the new platform #25914

[elasticmachine]

Pinging @elastic/infrastructure-ui

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[spalger]

Merged #25914 this morning, would you mind updating this to use the new chrome.breadcrumbs service? Also, would you mind describing the breadcrumb hierarchy for me (or we can walk through it in a call if you like)?

[weltenwort]

@spalger rebased on master and updated to use chrome.breadcrumbs. To do so properly I had to add the breadcrumbs property to the Chrome type. Since the breadcrumbs api itself is already written in TypeScript, I figured I could avoid spreading the type defs around by turning Chrome into an interface (it wasn't a class anyway) and pulling in the types from the api/breadcrumbs file. What do you think?

Regarding the breadcrumbs hierarchy, it's quite simple (maybe too simple). Every page just renders a <Header> with a sequence of breadcrumbs. There currently only are

• Infrastructure
• Infrastructure / Logs
• Infrastructure / ${nodeId}

I didn't what to mix in any changes to the hierarchy here to limit the scope of this PR.

[weltenwort]

Are the K7 header changes supposed to be backported to 6.x?

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[weltenwort]

same failure as on master (#26000)

[00:12:17]                   └- ✖ fail: "visualize app  visual builder switch index patterns should be able to switch between index patterns"
[00:12:17]                   │ 
[00:12:17]                   │       Error: expected '0' to sort of equal '10'
[00:12:17]                   │       + expected - actual
[00:12:17]                   │ 
[00:12:17]                   │       -0
[00:12:17]                   │       +10
[00:12:17]                   │       
[00:12:17]                   │       at Assertion.assert (node_modules/expect.js/index.js:96:13)
[00:12:17]                   │       at Assertion.eql (node_modules/expect.js/index.js:230:10)
[00:12:17]                   │       at Context.it (test/functional/apps/visualize/_tsvb_chart.js:238:29)
[00:12:17]                   │       at <anonymous>
[00:12:17]                   │       at process._tickCallback (internal/process/next_tick.js:188:7)

[spalger]

I have #25973 in to fix that @weltenwort. Jenkins, would you please test this?

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[skh]

Ensure the k7design UI settings is disabled.
Check that the old header is rendered.

👍

Enable the k7design UI setting.
Check that the K7 Header with correct breadcrumbs is rendered on the home page, the node detail page and the log page.

👍

Works as described. Code looks good.

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[weltenwort]

@tbragin given that the new header is behind a feature switch in the advanced settings, are we ok to merge this without the BETA badge being visible in K7 mode? Or do we want to find a different location for it before merging?

[tbragin]

I think we are ok w.o a beta label in K7, assuming we remain on track to GA Logs and Infrastructure before or in 7.0. If we don't meet that deadline, we could always add it back. @makwarth Do you have thoughts on this?

[makwarth]

@tbragin Agree 👍

[spalger]

@weltenwort was there a follow up issue to change which breadcrumbs are in use to follow the guidelines in #25689?

[weltenwort]

no, I was not aware of that. should be a simple task for the Infrastructure UI, but not necessarily for the other solutions. what is the plan and timeline to getting the solutions teams involved?

[spalger]

We'd really like to get the breadcrumbs all updated for alpha2, so if you or someone else has some time to throw at it this week that'd be great

[weltenwort]

ok, tracking it in #26582

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request