Make panel action tests more generic #22174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 20, 2018 12:12
💔 Build Failed |
added 2 commits
August 20, 2018 14:15
stacey-gammon
approved these changes
Aug 20, 2018
💔 Build Failed |
💔 Build Failed |
spalger
approved these changes
Aug 20, 2018
There was a problem hiding this comment.
I'd love to add a plugin to this that is generated by the plugin generator, and then treat that as a "snapshot" test for the plugin generator, making sure that is matches the generated output that is committed to the repo, and requiring that we update the snapshot and possible any tests whenever we update the plugin generator.
Code LGTM, relying on CI to verify it works.
💚 Build Succeeded |
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Aug 20, 2018
* Make panel action tests more generic * Remove test file * Add simple app tests * Shorten/fix import * Remove unneeded task * Add debug output * Allow duplicate --plugin-path params * Remove debugging options * Add README
timroes
added a commit
that referenced
this pull request
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the panel action tests more generic and giving the option of having plugin tests in general.
It also fixes the issue, that these weren't executed at all on CI and thus already were broken since #19261 when
envwas removed.@spalger this test suite might qualify later for pulling it into it's separate Jenkins job, right now it adds around 5 minutes to our build time☹️