fixing date_histogram to correctly work inside plugins without global time picker #21955
Conversation
ppisljar
added
review
Feature:Visualizations
💔 Build Failed |
There was a problem hiding this comment.
One adjustment in code. Also I would like, if we could split out the non time based index into it's own esarchiver image, since it's such a similar name to the other index, and I would rather not load that for all tests, since I see how this might lead to easy confusions.
If we split that index pattern into it's own archive, we could use:
const esArchiver = getService('esArchiver');
// ...
before(async () => {
await esArchiver.load('visualize-nontimeindex');
});
after(async () => {
await esArchiver.unload('visualize-nontimeindex');
});In those two tests, to actually load and unload that.
Maybe so we don't need to load this for every test suite individually, we could add two separate describe blocks visualize app and visualize app non time based into the index.js file for all visualize tests, so we can load this for the whole test block.
| @@ -541,6 +541,14 @@ export function VisualizePageProvider({ getService, getPageObjects }) { | |||
| async setInterval(newValue) { | |||
| const input = await find.byCssSelector('select[ng-model="agg.params.interval"]'); | |||
| await input.type(newValue); | |||
| await remote.pressKeys('\uE006'); | |||
There was a problem hiding this comment.
use:
import Keys from 'leadfoot/keys';
Keys.RETURN
ppisljar
force-pushed
the
fix/timeRange
branch
from
f67c224
to
c36c480
Compare
| expect(isApplyButtonEnabled).to.be(true); | ||
| }); | ||
|
|
||
| it('should allow resseting changed params', async () => { |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
|
looks relevant failiure, but just to be sure: retest |
|
retest |
💔 Build Failed |
ppisljar
force-pushed
the
fix/timeRange
branch
from
4655b64
to
bbf956e
Compare
💔 Build Failed |
💔 Build Failed |
ppisljar
force-pushed
the
fix/timeRange
branch
from
1a6b281
to
f5be9f2
Compare
|
jenkins, test this |
|
jenkins, test this |
💔 Build Failed |
💚 Build Succeeded |
resolves #21954
This PR removes the dependency to timeFilter from date histogram aggregations. So charts embedded via the visualize loader will still work in apps where no timeFilter is present.
For QA: This PR should not change any functionality in Kibana.