-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Address multiple accessibility issues #20619
Merged
chrisronline
merged 18 commits into
elastic:master
from
chrisronline:monitoring/accessibility
Aug 8, 2018
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
ea6f802
Add screen reader only text for monitoring charts
chrisronline 1bf8fdb
Add aria label for completed recoveries
chrisronline 08b2247
Ensure we have aria label coverage for monitoring chart tooltips
chrisronline deb0df8
Ensure table rows are tabbable and include the number of results at t…
chrisronline a4bcd32
Use EuiScreenReaderOnly
chrisronline 3f86b94
Updated copy
chrisronline c67a7b3
Use EUI
chrisronline 62f8683
Remove kui usage
chrisronline ca1b7af
Use an id instead of aria-label
chrisronline d622eb7
Show results in the table footer
chrisronline bf93d63
Revert "Show results in the table footer"
chrisronline 18cc017
Show total row count within the monitoring table
chrisronline 0f2fd25
PR feedback
chrisronline 7f98d5a
PR feedback
chrisronline ff6eea2
Merge remote-tracking branch 'elastic/master' into monitoring/accessi…
chrisronline ec68f59
Ensure all charts show an interval in the tooltip
chrisronline c813b48
Fix merge conflicts with master
chrisronline a8fd4f8
Fix padding issue with the cluster status
chrisronline File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does each cell really need to be tabbable? Is this just to make it visible to a screen-reader?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd imagine so, otherwise the screen reader can't read any of the content in non tabbable cells
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I've found this to be true myself. I was hoping there'd be another way :D