-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused destroy function and killed variable #20111
Remove unused destroy function and killed variable #20111
Conversation
💚 Build Succeeded |
90a3a6d
to
201da04
Compare
💔 Build Failed |
Couple failures:
and
I've seen the second one before, I think it's just flaky. First one also looks unrelated. jenkins, test this |
💔 Build Failed |
Failure on xpack tests:
jenkins, test this |
💚 Build Succeeded |
ping @kobelb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
code review. Looked for any calls to destroy method and could not find any.
FWIW, I can't find any myself either. I think this is fine to remove it, we're killing the underlying process which will cause the evaluate calls to throw an error and break the loop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yay for typescript, as it seems that
client.close()
is not a legit function, which lead me down a road to determine that this function isn't called at all, so killed is always true. I could be wrong, so I'll wait to check in with @kobelb before merging.