Resolve intermittent premature connection closed #19808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 8 changed the keepAlive to default to 5 seconds from 5 minutes. This reverts that behavior. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added
Team:Operations
jbudz
reviewed
Jun 11, 2018
| @@ -47,6 +51,9 @@ export function setupConnection(server, config) { | |||
| } | |||
| }); | |||
|
|
|||
| // revert to previous 5m keepalive timeout in Node < 8 | |||
jbudz
approved these changes
Jun 11, 2018
|
https://nodejs.org/api/http.html#http_server_keepalivetimeout has a blurb about it. New setting in Node 8. It mentions setting this to 0 for the same behavior as < 8 but 120 is effectively the same as it falls back to the timeout option above. |
💚 Build Succeeded |
tylersmalley
added a commit
that referenced
this pull request
Jun 11, 2018
Node 8 changed the keepAlive to default to 5 seconds from 5 minutes. This reverts that behavior. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added a commit
that referenced
this pull request
Jun 11, 2018
Node 8 changed the keepAlive to default to 5 seconds from 5 minutes. This reverts that behavior. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
💚 Build Succeeded |
maryia-lapata
pushed a commit
to maryia-lapata/kibana
that referenced
this pull request
Jun 25, 2018
Node 8 changed the keepAlive to default to 5 seconds from 5 minutes. This reverts that behavior. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
jbudz
pushed a commit
to jbudz/kibana
that referenced
this pull request
Mar 6, 2019
Node 8 changed the keepAlive to default to 5 seconds from 5 minutes. This reverts that behavior. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
jbudz
added a commit
that referenced
this pull request
Mar 8, 2019
* Bump node to 6.17.0 * Resolve intermittent premature connection closed (#19808) Node 8 changed the keepAlive to default to 5 seconds from 5 minutes. This reverts that behavior. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * 6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 8 changed the keepAlive default to 5 seconds from 5 minutes. This reverts that behavior.
Having this low of a keepAlive timeout is problematic for health checks. For example, if you have a Load Balancer health check on a 5-second interval, the initial request starts the keepAlive and it's possible a subsequent request uses the keepAlive and is destroyed before it has been completed.
hapijs/hapi#3738