Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detection Engine] update query automatically in rule create form through AI assistant #190963

Merged
merged 23 commits into from
Sep 3, 2024
Merged

[Security Solution][Detection Engine] update query automatically in rule create form through AI assistant #190963

merged 23 commits into from
Sep 3, 2024

Conversation

vitaliidm
Copy link
Contributor

@vitaliidm vitaliidm commented Aug 21, 2024 •
edited
Loading

Summary

UX

Introduced button in code block

Screenshot 2024-08-21 at 16 35 51

DEMO

Screen.Recording.2024-08-21.at.16.31.26.mov

Checklist

@vitaliidm vitaliidm self-assigned this Aug 21, 2024
@vitaliidm vitaliidm added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Engine Security Solution Detection Engine Area release_note:skip Skip the PR/issue when compiling release notes labels Aug 21, 2024
@vitaliidm
Copy link
Contributor Author

/ci

@vitaliidm
Copy link
Contributor Author

/ci

@vitaliidm
Copy link
Contributor Author

/ci

@vitaliidm
Copy link
Contributor Author

/ci

@vitaliidm
Copy link
Contributor Author

@ARWNightingale , @jamesspi

I've used the following icon

Screenshot 2024-08-21 at 16 35 51

Let me know, if you think there is a more suitable one for the use case

@vitaliidm vitaliidm marked this pull request as ready for review August 22, 2024 16:23
@vitaliidm vitaliidm requested review from a team as code owners August 22, 2024 16:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

@vitaliidm vitaliidm added 8.16 candidate release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels Aug 22, 2024
@jamesspi
Copy link

@ARWNightingale , @jamesspi

I've used the following icon

Screenshot 2024-08-21 at 16 35 51 Let me know, if you think there is a more suitable one for the use case

I like it!

nkhristinin
nkhristinin approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@nkhristinin nkhristinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! very nice addition.

spong
spong approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out, tested locally and code reviewed -- LGTM! 👍

Great enhancement here @vitaliidm! Thanks for the clean implementation and additional tests. Works great! 🚀

@vitaliidm vitaliidm enabled auto-merge (squash) September 3, 2024 16:16
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 5654 5656 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 17.9MB 20.6MB ⚠️ +2.7MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 86.4KB 86.4KB +8.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @vitaliidm

@vitaliidm vitaliidm merged commit 3c9198a into elastic:main Sep 3, 2024
39 checks passed
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Sep 3, 2024
@vitaliidm vitaliidm mentioned this pull request Sep 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong approved these changes

@nkhristinin nkhristinin nkhristinin approved these changes

@jamesspi jamesspi Awaiting requested review from jamesspi

@ARWNightingale ARWNightingale Awaiting requested review from ARWNightingale

Assignees

@vitaliidm vitaliidm

Labels
8.16 candidate backport:skip This commit does not require backporting release_note:enhancement Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vitaliidm @elasticmachine @jamesspi @kibana-ci @spong @nkhristinin @kibanamachine