Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Improve column parsing #190612

Merged
merged 7 commits into from
Aug 20, 2024
Merged

Conversation

vadimkibana
Copy link
Contributor

Summary

Fixes #189913

  • Adds parts field to { type: 'column' } AST nodes. The parts field contains a list of correctly parsed out column framents.
  • The existing text and name fields work only if a column does not have any escaped characters. However, I could not change/remove them, as lots of code is currently referring them.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@vadimkibana vadimkibana requested a review from a team as a code owner August 15, 2024 14:29
@vadimkibana vadimkibana added review release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana v8.16.0 labels Aug 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vadimkibana vadimkibana enabled auto-merge (squash) August 20, 2024 09:46
@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.3MB 3.3MB +386.0B
Unknown metric groups

API count

id before after diff
@kbn/esql-ast 149 150 +1

References to deprecated APIs

id before after diff
@kbn/esql-validation-autocomplete 0 2 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@vadimkibana vadimkibana merged commit 929d407 into elastic:main Aug 20, 2024
19 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes review Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) Team:ESQL ES|QL related features in Kibana v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ES|QL] Nested quoted column identifer parsing
6 participants