-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telemetry][Security Solution] Use the proper index to query builtin alerts #187859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaffarano
added
release_note:skip
Skip the PR/issue when compiling release notes
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
labels
Jul 9, 2024
Pinging @elastic/security-solution (Team: SecuritySolution) |
⏳ Build in-progress, with failures
Failed CI Steps
Test Failures
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
|
JDKurma
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 12, 2024
…alerts (elastic#187859) ## Summary elastic#177263 changed the way `telemetry-prebuilt-rule-alerts` get data from elastic, but it changed the index used to run the queries. This PR fixes it using the proper index. (cherry picked from commit a120c51)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 12, 2024
…uiltin alerts (#187859) (#188217) # Backport This will backport the following commits from `main` to `8.15`: - [[Telemetry][Security Solution] Use the proper index to query builtin alerts (#187859)](#187859) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sebastián Zaffarano","email":"sebastian.zaffarano@elastic.co"},"sourceCommit":{"committedDate":"2024-07-12T13:17:43Z","message":"[Telemetry][Security Solution] Use the proper index to query builtin alerts (#187859)\n\n## Summary\r\n\r\nhttps://github.com//pull/177263 changed the way\r\n`telemetry-prebuilt-rule-alerts` get data from elastic, but it changed\r\nthe index used to run the queries. This PR fixes it using the proper\r\nindex.","sha":"a120c510b9738aab0fb5f9296515a82f6f0792a6","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team: SecuritySolution","v8.14.0","v8.15.0","v8.16.0"],"title":"[Telemetry][Security Solution] Use the proper index to query builtin alerts","number":187859,"url":"https://github.com/elastic/kibana/pull/187859","mergeCommit":{"message":"[Telemetry][Security Solution] Use the proper index to query builtin alerts (#187859)\n\n## Summary\r\n\r\nhttps://github.com//pull/177263 changed the way\r\n`telemetry-prebuilt-rule-alerts` get data from elastic, but it changed\r\nthe index used to run the queries. This PR fixes it using the proper\r\nindex.","sha":"a120c510b9738aab0fb5f9296515a82f6f0792a6"}},"sourceBranch":"main","suggestedTargetBranches":["8.14","8.15"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/187859","number":187859,"mergeCommit":{"message":"[Telemetry][Security Solution] Use the proper index to query builtin alerts (#187859)\n\n## Summary\r\n\r\nhttps://github.com//pull/177263 changed the way\r\n`telemetry-prebuilt-rule-alerts` get data from elastic, but it changed\r\nthe index used to run the queries. This PR fixes it using the proper\r\nindex.","sha":"a120c510b9738aab0fb5f9296515a82f6f0792a6"}}]}] BACKPORT--> Co-authored-by: Sebastián Zaffarano <sebastian.zaffarano@elastic.co>
szaffarano
added a commit
that referenced
this pull request
Jul 15, 2024
…uiltin alerts (#187859) (#188235) # Backport This will backport the following commits from `main` to `8.14`: - [[Telemetry][Security Solution] Use the proper index to query builtin alerts (#187859)](#187859) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sebastián Zaffarano","email":"sebastian.zaffarano@elastic.co"},"sourceCommit":{"committedDate":"2024-07-12T13:17:43Z","message":"[Telemetry][Security Solution] Use the proper index to query builtin alerts (#187859)\n\n## Summary\r\n\r\nhttps://github.com//pull/177263 changed the way\r\n`telemetry-prebuilt-rule-alerts` get data from elastic, but it changed\r\nthe index used to run the queries. This PR fixes it using the proper\r\nindex.","sha":"a120c510b9738aab0fb5f9296515a82f6f0792a6","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team: SecuritySolution","v8.14.0","v8.15.0","v8.16.0"],"title":"[Telemetry][Security Solution] Use the proper index to query builtin alerts","number":187859,"url":"https://github.com/elastic/kibana/pull/187859","mergeCommit":{"message":"[Telemetry][Security Solution] Use the proper index to query builtin alerts (#187859)\n\n## Summary\r\n\r\nhttps://github.com//pull/177263 changed the way\r\n`telemetry-prebuilt-rule-alerts` get data from elastic, but it changed\r\nthe index used to run the queries. This PR fixes it using the proper\r\nindex.","sha":"a120c510b9738aab0fb5f9296515a82f6f0792a6"}},"sourceBranch":"main","suggestedTargetBranches":["8.14","8.15"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/187859","number":187859,"mergeCommit":{"message":"[Telemetry][Security Solution] Use the proper index to query builtin alerts (#187859)\n\n## Summary\r\n\r\nhttps://github.com//pull/177263 changed the way\r\n`telemetry-prebuilt-rule-alerts` get data from elastic, but it changed\r\nthe index used to run the queries. This PR fixes it using the proper\r\nindex.","sha":"a120c510b9738aab0fb5f9296515a82f6f0792a6"}}]}] BACKPORT--> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
v8.14.0
v8.14.4
v8.15.0
v8.16.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#177263 changed the way
telemetry-prebuilt-rule-alerts
get data from elastic, but it changed the index used to run the queries. This PR fixes it using the proper index.Checklist