-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for kibana:plugin_render_time
#184206
Merged
kpatticha
merged 9 commits into
elastic:main
from
kpatticha:doc_kibana_plugin_render_time
May 29, 2024
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3f664c8
Add documentation for `kibana:plugin_render_time`
kpatticha df82fae
Add dashboard links
kpatticha 216ae6a
Fix typo
kpatticha 10ff8df
Merge branch 'main' into doc_kibana_plugin_render_time
kpatticha 6875da7
Merge branch 'main' into doc_kibana_plugin_render_time
kpatticha 911d63e
Update dev_docs/tutorials/performance/adding_custom_performance_metri…
kpatticha 14ead00
Update dev_docs/tutorials/performance/adding_custom_performance_metri…
kpatticha 2cf8e95
Update dev_docs/tutorials/performance/adding_custom_performance_metri…
kpatticha d7b0048
Merge branch 'main' into doc_kibana_plugin_render_time
kpatticha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question. Are we sure its the start of the navigation? Not the Kibana plugin start time ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What we want is form the browser navigation start time. I am not sure if we are capturing that, If not we need to change the implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The performance mark
start::pageChange
is set on route change and thekibana:plugin_render_time
is the duration between thestart::pageChange
and theend::pageReady
.However, I've noticed that there are more than one markers for
start::pageChange
per route and theperformance.measure
gets the latest marker forstart::pageChange
. it seems to be due to re-render.kibana/packages/kbn-ebt-tools/src/performance_metrics/context/performance_context.tsx
Line 41 in a4f468b
I believe I need to fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is other way to do this, Where you don't need to set marks on mount start/end. To truly measure based on the navigation time, we could do
performance.measure("render-time)"
this would get the metric between the Nav time and when the page is ready.Thanks for checking, it seems as you mentioned we need a followup to fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where should we do the
performance.measure("render-time)
? I think I missed this partThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi the ticket: https://github.com/elastic/kibana/issues/184390
Feel free to update it