Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Fix tooltip size and partition rerendering #172802

Merged
merged 2 commits into from
Dec 7, 2023
Merged

[Lens] Fix tooltip size and partition rerendering #172802

merged 2 commits into from
Dec 7, 2023

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Dec 7, 2023 •
edited by kibanamachine
Loading

Summary

fix #171408
improves the style of tooltip by enlarging its size see elastic/elastic-charts#2048

@markov00 markov00 added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@markov00 markov00 added the release_note:skip Skip the PR/issue when compiling release notes label Dec 7, 2023
@stratoula stratoula requested a review from a team December 7, 2023 11:37
stratoula
stratoula approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, changes LGTM!

@markov00 markov00 requested a review from a team as a code owner December 7, 2023 13:29
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 374.9KB 374.9KB +36.0B
kbnUiSharedDeps-npmDll 6.2MB 6.2MB +32.0B
total +68.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@markov00 markov00 enabled auto-merge (squash) December 7, 2023 15:09
smith
smith approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snapshot change in uptime looks good 👍🏻

@markov00 markov00 merged commit f684005 into elastic:main Dec 7, 2023
41 checks passed
@kibanamachine kibanamachine mentioned this pull request Dec 7, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 7, 2023
@markov00
[Lens] Fix tooltip size and partition rerendering (elastic#172802)
24d1b40 
## Summary

fix elastic#171408
improves the style of tooltip by enlarging its size see
elastic/elastic-charts#2048

(cherry picked from commit f684005)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 7, 2023
@kibanamachine @markov00
[8.12] [Lens] Fix tooltip size and partition rerendering (#172802) (#…
f0cdb00 
…172890)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[Lens] Fix tooltip size and partition rerendering
(#172802)](#172802)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco
Vettorello","email":"marco.vettorello@elastic.co"},"sourceCommit":{"committedDate":"2023-12-07T20:55:24Z","message":"[Lens]
Fix tooltip size and partition rerendering (#172802)\n\n##
Summary\r\n\r\nfix
https://github.com/elastic/kibana/issues/171408\r\nimproves the style of
tooltip by enlarging its size
see\r\nhttps://github.com/elastic/elastic-charts/issues/2048","sha":"f6840055d4c828787aab742ce082ab8911e8a5a9","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Visualizations","release_note:skip","backport:prev-minor","v8.12.0","v8.13.0"],"number":172802,"url":"https://github.com/elastic/kibana/pull/172802","mergeCommit":{"message":"[Lens]
Fix tooltip size and partition rerendering (#172802)\n\n##
Summary\r\n\r\nfix
https://github.com/elastic/kibana/issues/171408\r\nimproves the style of
tooltip by enlarging its size
see\r\nhttps://github.com/elastic/elastic-charts/issues/2048","sha":"f6840055d4c828787aab742ce082ab8911e8a5a9"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172802","number":172802,"mergeCommit":{"message":"[Lens]
Fix tooltip size and partition rerendering (#172802)\n\n##
Summary\r\n\r\nfix
https://github.com/elastic/kibana/issues/171408\r\nimproves the style of
tooltip by enlarging its size
see\r\nhttps://github.com/elastic/elastic-charts/issues/2048","sha":"f6840055d4c828787aab742ce082ab8911e8a5a9"}}]}]
BACKPORT-->

Co-authored-by: Marco Vettorello <marco.vettorello@elastic.co>
@markov00 markov00 deleted the 2023_12_07-update_elastic-charts branch December 11, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smith smith smith approved these changes

@stratoula stratoula stratoula approved these changes

@nickofthyme nickofthyme nickofthyme approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.12.0 v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] embedded pie chart disappears after resize
7 participants
@markov00 @elasticmachine @kibana-ci @kibanamachine @smith @stratoula @nickofthyme