[alerting_example] Migrate deprecated EuiPage* components
#168299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
added
release_note:skip
4 tasks
cee-chen
changed the title
EuiPage* componentsEuiPage* components
|
Pinging @elastic/eui-team (EUI) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
|
@elastic/response-ops Any chance we can get a review on this before EOW? This is blocking EUI's ability to deprecate the component. |
|
Thanks a million! |
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Oct 17, 2023
…168299) ## Summary > Note: I strongly recommending [viewing the diff with whitespace changes turned off](https://github.com/elastic/kibana/pull/168300/files?w=1), as many of the "changes" are simply indentation changes. EUI will shortly be removing several deprecated `EuiPage*` components, and we're updating a few remaining Kibana usages of these deprecated components ahead of time.⚠️ PLEASE NOTE: We have **not** QA'd these changes to ensure that the UI is 1:1 from before. We do not have the domain knowledge or time to spin up local instances of all plugins with deprecations, and ask that the CODEOWNING team pull down this branch and QA the affected page(s) locally to ensure the UI looks like the same as production.⚠️ See elastic#161872 for other similar tasks with more information about this effort.
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Oct 22, 2023
…168299) ## Summary > Note: I strongly recommending [viewing the diff with whitespace changes turned off](https://github.com/elastic/kibana/pull/168300/files?w=1), as many of the "changes" are simply indentation changes. EUI will shortly be removing several deprecated `EuiPage*` components, and we're updating a few remaining Kibana usages of these deprecated components ahead of time.⚠️ PLEASE NOTE: We have **not** QA'd these changes to ensure that the UI is 1:1 from before. We do not have the domain knowledge or time to spin up local instances of all plugins with deprecations, and ask that the CODEOWNING team pull down this branch and QA the affected page(s) locally to ensure the UI looks like the same as production.⚠️ See elastic#161872 for other similar tasks with more information about this effort.
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Oct 22, 2023
…168299) ## Summary > Note: I strongly recommending [viewing the diff with whitespace changes turned off](https://github.com/elastic/kibana/pull/168300/files?w=1), as many of the "changes" are simply indentation changes. EUI will shortly be removing several deprecated `EuiPage*` components, and we're updating a few remaining Kibana usages of these deprecated components ahead of time.⚠️ PLEASE NOTE: We have **not** QA'd these changes to ensure that the UI is 1:1 from before. We do not have the domain knowledge or time to spin up local instances of all plugins with deprecations, and ask that the CODEOWNING team pull down this branch and QA the affected page(s) locally to ensure the UI looks like the same as production.⚠️ See elastic#161872 for other similar tasks with more information about this effort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
EUI will shortly be removing several deprecated
EuiPage*components, and we're updating a few remaining Kibana usages of these deprecated components ahead of time.See #161872 for other similar tasks with more information about this effort.