fix(slo): rollback when errors happen during the update use case #168142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
kdelemme
added
release_note:skip
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @kdelemme |
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 6, 2023
…stic#168142) (cherry picked from commit 377a3e4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kdelemme
added a commit
to kdelemme/kibana
that referenced
this pull request
Oct 6, 2023
kibanamachine
added a commit
that referenced
this pull request
Oct 6, 2023
…se (#168142) (#168221) # Backport This will backport the following commits from `main` to `8.11`: - [fix(slo): rollback when errors happen during the update use case (#168142)](#168142) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2023-10-06T13:28:41Z","message":"fix(slo): rollback when errors happen during the update use case (#168142)","sha":"377a3e499c72dac6415a36e20e3846c1bf36a354","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team: Actionable Observability","backport:prev-minor","Feature:SLO","v8.12.0"],"number":168142,"url":"https://github.com/elastic/kibana/pull/168142","mergeCommit":{"message":"fix(slo): rollback when errors happen during the update use case (#168142)","sha":"377a3e499c72dac6415a36e20e3846c1bf36a354"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168142","number":168142,"mergeCommit":{"message":"fix(slo): rollback when errors happen during the update use case (#168142)","sha":"377a3e499c72dac6415a36e20e3846c1bf36a354"}}]}] BACKPORT--> Co-authored-by: Kevin Delemme <kevin.delemme@elastic.co>
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #167938
Resolves #168051
Summary
This PR changes the update SLO use case to make it more resilient to errors happening at any step of the flow.
We moved the deletion of the original SLO data (rollup and summary) at the very end of the flow, and we handle errors at every step, and always restore the original SLO.