[kbn-journey] temporary disable APM for ES #167810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlemeshko
added
v8.11.0
release_note:skip
Ikuni17
approved these changes
Oct 2, 2023
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
dmlemeshko
added a commit
that referenced
this pull request
Oct 6, 2023
## Summary In #167810 I disabled APM for ES due to ES crash. The issue was fixed and it is working for me locally. perf journeys pipeline check https://buildkite.com/elastic/kibana-single-user-performance/builds/11578 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 6, 2023
…68198) ## Summary In elastic#167810 I disabled APM for ES due to ES crash. The issue was fixed and it is working for me locally. perf journeys pipeline check https://buildkite.com/elastic/kibana-single-user-performance/builds/11578 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 96e785d)
kibanamachine
added a commit
that referenced
this pull request
Oct 10, 2023
…68198) (#168220) # Backport This will backport the following commits from `main` to `8.11`: - [[journeys] re-enable APM instrumentation for Elasticsearch (#168198)](#168198) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2023-10-06T13:18:20Z","message":"[journeys] re-enable APM instrumentation for Elasticsearch (#168198)\n\n## Summary\r\n\r\nIn #167810 I disabled APM for ES due to ES crash. The issue was fixed\r\nand it is working for me locally.\r\n\r\nperf journeys pipeline check\r\nhttps://buildkite.com/elastic/kibana-single-user-performance/builds/11578\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"96e785d7cf3af9a0cebeea904a1cadc7a2d9a804","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","wg:performance","v8.12.0","v8.11.1"],"number":168198,"url":"https://github.com/elastic/kibana/pull/168198","mergeCommit":{"message":"[journeys] re-enable APM instrumentation for Elasticsearch (#168198)\n\n## Summary\r\n\r\nIn #167810 I disabled APM for ES due to ES crash. The issue was fixed\r\nand it is working for me locally.\r\n\r\nperf journeys pipeline check\r\nhttps://buildkite.com/elastic/kibana-single-user-performance/builds/11578\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"96e785d7cf3af9a0cebeea904a1cadc7a2d9a804"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168198","number":168198,"mergeCommit":{"message":"[journeys] re-enable APM instrumentation for Elasticsearch (#168198)\n\n## Summary\r\n\r\nIn #167810 I disabled APM for ES due to ES crash. The issue was fixed\r\nand it is working for me locally.\r\n\r\nperf journeys pipeline check\r\nhttps://buildkite.com/elastic/kibana-single-user-performance/builds/11578\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"96e785d7cf3af9a0cebeea904a1cadc7a2d9a804"}},{"branch":"8.11","label":"v8.11.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Oct 17, 2023
…68198) ## Summary In elastic#167810 I disabled APM for ES due to ES crash. The issue was fixed and it is working for me locally. perf journeys pipeline check https://buildkite.com/elastic/kibana-single-user-performance/builds/11578 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Disable APM for ES until elastic/elasticsearch/issues/100072 is fixed
It will unblock our performance pipelines that were failing since ES snapshot was promoted on Sept 30th.
The last working with APM one can be tested with:
ES_SNAPSHOT_MANIFEST="https://storage.googleapis.com/kibana-ci-es-snapshots-daily/8.11.0/archives/20230929-142326_e08153e2/manifest.json"