Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] expandable flyout - add no data message in entities details and entities overview components #164955

Merged
merged 2 commits into from
Aug 29, 2023
Merged

[Security Solution] expandable flyout - add no data message in entities details and entities overview components #164955

merged 2 commits into from
Aug 29, 2023

Conversation

PhilippeOberti
Copy link
Contributor

@PhilippeOberti PhilippeOberti commented Aug 28, 2023 •
edited by kibanamachine
Loading

Summary

This PR adds a no-data message to the entities details and entities overview section (in the expandable left and right panels respectively).

The entities details was showing a blank page, which isn't UX friendly.
The entities overview show hiding its section, which was a desired behavior in an earlier implementation. We recently switched to always showing all sections, and render a no-data message if nothing is to be displayed.

With data
Screenshot 2023-08-28 at 11 16 12 AM

No data previous behavior
Screenshot 2023-08-28 at 11 30 40 AM

No data new behavior (with no-data message)
Screenshot 2023-08-28 at 11 16 50 AM

Fixes #164951

Checklist

Delete any items that are not applicable to this PR.

@PhilippeOberti PhilippeOberti requested a review from a team as a code owner August 28, 2023 09:34
@PhilippeOberti PhilippeOberti mentioned this pull request Aug 28, 2023
Closed
@PhilippeOberti PhilippeOberti force-pushed the expandable-flyout-entities-details-no-data branch from 44abad5 to a3964c2 Compare August 28, 2023 16:52
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.6MB 12.6MB +1.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@PhilippeOberti PhilippeOberti merged commit 34c7a03 into main Aug 29, 2023
35 checks passed
@PhilippeOberti PhilippeOberti deleted the expandable-flyout-entities-details-no-data branch August 29, 2023 07:54
@kibanamachine kibanamachine mentioned this pull request Aug 29, 2023
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 29, 2023
@PhilippeOberti
[Security Solution] expandable flyout - add no data message in entiti…
6066a6c 
…es details and entities overview components (elastic#164955)

(cherry picked from commit 34c7a03)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 29, 2023
@jloleysens
Merge branch 'main' into run-migrations-on-migrator
44333f6 
* main: (40 commits)
  Adjust migrations and elasticsearch service settings for serverless. (elastic#165050)
  [Security Solution] expandable flyout - add investigate in timeline f… (elastic#165025)
  [SecuritySolution] Hide create dashboard button from listing (elastic#164476)
  Construct HTTP log message only if needed (elastic#165057)
  [Security Solution] expandable flyout - add no data message in entities details and entities overview components (elastic#164955)
  Add functional tests for serverless security management UIs (elastic#164886)
  [api-docs] 2023-08-29 Daily api_docs build (elastic#165056)
  [Cloud Security][CIS GCP]cis gcp now use updated gcp field name + small last minute changes (elastic#164792)
  [Security Solution] Expandable flyout - update risk classification ui in entities overview (elastic#165022)
  [Security Solution] Fixes Preconfigured Connectors not working with Assistant (elastic#164900)
  [Security Solution] Coverage Overview follow-up 2 (elastic#164986)
  [DOCS] Add cross-link for other encryption key settings (elastic#165014)
  chore(slo): general enhancement (elastic#164723)
  Revert "[SOR] Allow optionally downgrading documents with a higher version model in API READ methods" (elastic#164991)
  [OAS] Add more Elasticsearch query rule examples (elastic#164386)
  [security_solution_cypress] Add support for options in EsArchiver.load (elastic#164988)
  [Event Log] Skip setting assets to hidden in serverless (elastic#164767)
  remove unneeded usages of isErrorResponse (elastic#164609)
  [Enterprise Search] Make network drive connector platinum (elastic#165007)
  [RAM] update api key to become public (elastic#164883)
  ...
kibanamachine added a commit that referenced this pull request Aug 29, 2023
@kibanamachine @PhilippeOberti
[8.10] [Security Solution] expandable flyout - add no data message in…
3097906 
… entities details and entities overview components (#164955) (#165062)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[Security Solution] expandable flyout - add no data message in
entities details and entities overview components
(#164955)](#164955)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Philippe
Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2023-08-29T07:54:40Z","message":"[Security
Solution] expandable flyout - add no data message in entities details
and entities overview components
(#164955)","sha":"34c7a03016138cc1bae8296e1bb25bf4e73a8f4d","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Threat
Hunting:Investigations","v8.10.0","v8.11.0"],"number":164955,"url":"https://github.com/elastic/kibana/pull/164955","mergeCommit":{"message":"[Security
Solution] expandable flyout - add no data message in entities details
and entities overview components
(#164955)","sha":"34c7a03016138cc1bae8296e1bb25bf4e73a8f4d"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164955","number":164955,"mergeCommit":{"message":"[Security
Solution] expandable flyout - add no data message in entities details
and entities overview components
(#164955)","sha":"34c7a03016138cc1bae8296e1bb25bf4e73a8f4d"}}]}]
BACKPORT-->

Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
bryce-b pushed a commit to bryce-b/kibana that referenced this pull request Sep 19, 2023
@PhilippeOberti @bryce-b
[Security Solution] expandable flyout - add no data message in entiti…
59dca9b 
…es details and entities overview components (elastic#164955)
This was referenced Oct 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christineweng christineweng christineweng approved these changes

Assignees
No one assigned
Labels
release_note:enhancement Team:Threat Hunting:Investigations Security Solution Investigations Team v8.10.0 v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solution] Empty entities flyout when there is no user and host data
4 participants
@PhilippeOberti @kibana-ci @kibanamachine @christineweng