Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detection Engione] memoize SelectRuleType component on rule edit/create page #161012

Merged
merged 18 commits into from
Jul 17, 2023
Merged

[Security Solution][Detection Engione] memoize SelectRuleType component on rule edit/create page #161012

merged 18 commits into from
Jul 17, 2023

Conversation

vitaliidm
Copy link
Contributor

@vitaliidm vitaliidm commented Jun 30, 2023 •
edited
Loading

Summary

Small improvement, part of #159380
Memoizing SelectRuleType saves ~16-20ms, around 25% faster for form re-render

Before

Screenshot 2023-06-30 at 14 53 23

After

Screenshot 2023-06-30 at 14 55 28

@vitaliidm vitaliidm added release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Creation Security Solution Detection Rule Creation Team:Detection Engine Security Solution Detection Engine Area v8.10.0 labels Jun 30, 2023
@vitaliidm vitaliidm self-assigned this Jun 30, 2023
@vitaliidm vitaliidm marked this pull request as ready for review July 10, 2023 12:43
@vitaliidm vitaliidm requested a review from a team as a code owner July 10, 2023 12:43
@vitaliidm vitaliidm requested a review from spong July 10, 2023 12:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

spong
spong approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for swooping in and taking care of this perf issue @vitaliidm! LGTM! 👍

Sorry for the delay in approval here, been a little busy over in Assistant Land

@vitaliidm vitaliidm enabled auto-merge (squash) July 17, 2023 09:56
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.8MB 9.8MB +94.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @vitaliidm

@vitaliidm vitaliidm merged commit 55bb58b into elastic:main Jul 17, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 17, 2023
@vitaliidm vitaliidm deleted the alerts_8_10/memoize-rule-types branch March 4, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong approved these changes

Assignees

@vitaliidm vitaliidm

Labels
backport:skip This commit does not require backporting Feature:Rule Creation Security Solution Detection Rule Creation release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vitaliidm @elasticmachine @kibana-ci @spong @kibanamachine