[Archive Migrations] don't use es_archiver/empty_kibana in Shakespeare tests #137797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ref HEAD~1..HEAD --fix'
…updateShakespeareTest
|
@elasticmachine merge upstream |
LeeDr
changed the title
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-qa (Team:QA) |
wayneseymour
approved these changes
Aug 3, 2022
LeeDr
added
v8.4.0
auto-backport
kibanamachine
pushed a commit
that referenced
this pull request
Aug 4, 2022
…e tests (#137797) * don't use es_archiver/empty_kibana, speed up steps * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * revert change to listing page * revert this change and do in another PR Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 148381b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
LeeDr
removed
the
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 5, 2022
…e tests (elastic#137797) (elastic#138176) * don't use es_archiver/empty_kibana, speed up steps * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * revert change to listing page * revert this change and do in another PR Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 148381b) Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #137327
Also part of: #102552
This PR replaces calls to
esArchiver.load('test/functional/fixtures/es_archiver/empty_kibana',with a call tokibanaServer.savedObjects.cleanStandardList()to clean up in the before and after methods.This PR is not removing
es_archiver/empty_kibanaas there are still a lot of places using it