[Archive Migrations] x-pack dashboard/session_in_spaces #136531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wayneseymour
added
test_xpack_functional
release_note:skip
wayneseymour
force-pushed
the
migrations/dashboard-session_in_space
branch
6 times, most recently
from
0990563
to
29a2005
Compare
wayneseymour
force-pushed
the
migrations/dashboard-session_in_space
branch
4 times, most recently
from
c75d501
to
610fd20
Compare
|
buildkite test this |
wayneseymour
force-pushed
the
migrations/dashboard-session_in_space
branch
2 times, most recently
from
03bfa22
to
a912e83
Compare
wayneseymour
force-pushed
the
migrations/dashboard-session_in_space
branch
5 times, most recently
from
8d9d399
to
7ae4356
Compare
|
buildkite test this |
wayneseymour
force-pushed
the
migrations/dashboard-session_in_space
branch
5 times, most recently
from
0b2c104
to
3cf247d
Compare
Done @Dosant 👍🏾 |
Dosant
approved these changes
Aug 25, 2022
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
From the PR description. Is this still in the PR? I think sessions are being deleted through the API? |
@LeeDr, It is no longer in the PR as we fixed it in wayneseymour#1 |
Mpdreamz
pushed a commit
to Mpdreamz/kibana
that referenced
this pull request
Sep 6, 2022
* [Archive Migrations] x-pack dashboard/session_in_spaces Replaces the old es archive with kbn archive. Change test to use new archive. Helps with: elastic#102552 * fix deleting sessions * improve Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the old es archive with kbn archive.
Change test to use new archive.
Helps with: #102552
Details
Split the original archive into two, corresponding to their space names
Drop some before / after method duplication.