Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Archive Migrations] x-pack..lens/reporting #136262

Merged

Conversation

wayneseymour
Copy link
Member

Summary

Replaces the old es archive with kbn archive.
Change test to use new archive.

Helps with: #102552

@wayneseymour wayneseymour added test_xpack_functional release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.4.0 labels Jul 13, 2022
@wayneseymour wayneseymour self-assigned this Jul 13, 2022
@wayneseymour wayneseymour force-pushed the migrations/xpack-lens-reporting branch from 785f0cf to b72b68b Compare July 13, 2022 09:44
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @wayneseymour

@wayneseymour wayneseymour marked this pull request as ready for review July 13, 2022 12:03
@wayneseymour wayneseymour requested review from a team as code owners July 13, 2022 12:03
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VisEditors changes LGTM

@wayneseymour wayneseymour requested review from tsullivan and a team July 13, 2022 14:38
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is requiring another review from VisEditors - should be covered by my last review. Retrying...

@wayneseymour
Copy link
Member Author

@flash1293 thanks very much Mr Flash! :)

Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wayneseymour wayneseymour merged commit 2aa000b into elastic:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes test_xpack_functional v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants