[Archive Migration] x-pack spaces/enter_space #135200
Conversation
wayneseymour
added
Team:QA
wayneseymour
force-pushed
the
migrations/spaces-enter-space
branch
from
d2300ad
to
d007e92
Compare
|
Pinging @elastic/kibana-qa (Team:QA) |
|
ACK: reviewing... |
| "defaultRoute": "http://example.com/evil" | ||
| }, | ||
| "coreMigrationVersion": "8.4.0", | ||
| "id": "6.0.0", |
There was a problem hiding this comment.
issue: hmm, this will just create a second config object for Kibana 6.0.0 that won't be used. We need to this id to match the version of the Kibana instance.
It looks like kibanaServer.importExport.load doesn't allow you to dynamically change the id, and we'd need to use kibanaServer.savedObjects instead. Do you think something like this would be possible?
// Assets that config object really exists
const config = await kibanaServer.savedObjects.get({
id: await kibanaServer.version.get(),
type: 'config',
});
// Update config object
await kibanaServer.savedObjects.update({
id: config.id,
type: config.type,
attributes: { defaultRoute: 'http://example.com/evil' },
});There was a problem hiding this comment.
Shouldn't the tests fail then?
There was a problem hiding this comment.
Also, the original archive had this value as well:
https://github.com/elastic/kibana/pull/135200/files#diff-d28b72a9dbee1ef40c778198307d043b2e515984b1e316fde3280eb81e75de1dL4
wayneseymour
force-pushed
the
migrations/spaces-enter-space
branch
from
e20fc3b
to
370dad8
Compare
wayneseymour
force-pushed
the
migrations/spaces-enter-space
branch
from
370dad8
to
f04b5f5
Compare
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
| @@ -0,0 +1,33 @@ | |||
| { | |||
There was a problem hiding this comment.
nit: I don't think we need this file anymore (file isn't imported in the tests and we update config object directly via Saved Object API)?
Drop unused archive
* [Archive Migration] x-pack spaces/enter_space * Replace the archive definitions with code. * Add the malformed url to the kbn archive, thanks to a tip from Oleg Zasypkin. * Drop exclusive. * Use Oleg's suggestion. * Whoops.
Summary
Migrate and drop old archive.
Make the test use the new archive.