Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Archive Migration] replace es_archive with kbn_archive invalid_scripted_field.json #125321

Merged
merged 8 commits into from
Feb 16, 2022

Conversation

LeeDr
Copy link
Contributor

@LeeDr LeeDr commented Feb 10, 2022

Summary

Part of #102552
The invalid_scripted_field es_archive had a copy in test/functional/fixtures and x-pack/test/functional/fixtures. I changed the tests to all point to the one new kbn_archive in test/functional/fixtures.

@LeeDr LeeDr changed the title replace es_archive with kbn_archive invalid_scripted_field.json [Archive Migration] replace es_archive with kbn_archive invalid_scripted_field.json Feb 10, 2022
@LeeDr LeeDr added Feature:Functional Testing release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team test_ui_functional test_xpack_functional v7.17.1 v8.0.1 v8.1.0 v8.2.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Feb 10, 2022
@LeeDr
Copy link
Contributor Author

LeeDr commented Feb 15, 2022

The test failed once, but passes locally. I'll merge upstream and see if it fails again. Here's the failure;

└-: errors
--
  | └-> "before all" hook: beforeTestSuite.trigger in "errors"
  | └-> "before all" hook in "errors"
  | └-: invalid scripted field error
  | └-> "before all" hook: beforeTestSuite.trigger for "is rendered"
  | └-> is rendered
  | └-> "before each" hook: global before each for "is rendered"
  | └- ✖ fail: discover app errors invalid scripted field error is rendered
  | │      NoSuchElementError: no such element: Unable to locate element: {"method":"css selector","selector":".euiToast:nth-child(1)"}
  | │   (Session info: headless chrome=98.0.4758.80)
  | │       at Object.throwDecodedError (node_modules/selenium-webdriver/lib/error.js:522:15)
  | │       at parseHttpResponse (node_modules/selenium-webdriver/lib/http.js:548:13)
  | │       at Executor.execute (node_modules/selenium-webdriver/lib/http.js:474:28)
  | │       at runMicrotasks (<anonymous>)
  | │       at processTicksAndRejections (node:internal/process/task_queues:96:5)
  | │       at Task.exec (test/functional/services/remote/prevent_parallel_calls.ts:28:20)
  |  

@LeeDr
Copy link
Contributor Author

LeeDr commented Feb 15, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@LeeDr LeeDr marked this pull request as ready for review February 15, 2022 19:57
@LeeDr LeeDr requested a review from a team as a code owner February 15, 2022 19:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, nice cleanup, DataDiscovery.team owned code review, didn't test

@LeeDr LeeDr merged commit 4319ea8 into elastic:main Feb 16, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 16, 2022
…ted_field.json (elastic#125321)

* remove es_archive with kbn_archive invalid_scripted_field.json

* remove unused es_archive files

* replace another usage of es_archives/invalid_scripted_field

* clear any existing index patterns before loading our new one

* remove .only

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 4319ea8)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 16, 2022
…ted_field.json (elastic#125321)

* remove es_archive with kbn_archive invalid_scripted_field.json

* remove unused es_archive files

* replace another usage of es_archives/invalid_scripted_field

* clear any existing index patterns before loading our new one

* remove .only

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 4319ea8)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 16, 2022
…ted_field.json (elastic#125321)

* remove es_archive with kbn_archive invalid_scripted_field.json

* remove unused es_archive files

* replace another usage of es_archives/invalid_scripted_field

* clear any existing index patterns before loading our new one

* remove .only

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 4319ea8)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.1
8.0
7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 16, 2022
…ted_field.json (#125321) (#125815)

* remove es_archive with kbn_archive invalid_scripted_field.json

* remove unused es_archive files

* replace another usage of es_archives/invalid_scripted_field

* clear any existing index patterns before loading our new one

* remove .only

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 4319ea8)

Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
kibanamachine added a commit that referenced this pull request Feb 16, 2022
…ted_field.json (#125321) (#125814)

* remove es_archive with kbn_archive invalid_scripted_field.json

* remove unused es_archive files

* replace another usage of es_archives/invalid_scripted_field

* clear any existing index patterns before loading our new one

* remove .only

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 4319ea8)

Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
kibanamachine added a commit that referenced this pull request Feb 16, 2022
…ted_field.json (#125321) (#125813)

* remove es_archive with kbn_archive invalid_scripted_field.json

* remove unused es_archive files

* replace another usage of es_archives/invalid_scripted_field

* clear any existing index patterns before loading our new one

* remove .only

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 4319ea8)

Co-authored-by: Lee Drengenberg <lee.drengenberg@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Functional Testing release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team test_ui_functional test_xpack_functional v7.17.1 v8.0.1 v8.1.0 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants