[5.x] Filter editors (#11375) #12184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add terms filter * First stab at inline filter editors * Cleanup * Move endpoint to server * Add delete button to filter editor * Add sort prefix first utility * Sort ui-select items by prefix first * Add sortPrefixFirst tests * Use small text input instead of styles * More keyboard-driven filter creation * Add custom dsl edit support * Add more actions * Add alias support * Simplify label * Allow freeform entries * Fix visualize * Support for dashboard * Move styles to less and fix visual issues * Rename map_match to map_phrase * Detect scripted filters for filter editors * Simplify range map * Use match_phrase instead of terms * Fix scripted exists * Support scripted phrases * Don't show DSL editor for new filters * Disable save unless valid * Fix error when searching for numbers * Return correct error and dont suggest values for numbers * Only suggest filterable fields * Clear params on field change * Clear suggestions on field change * Cache response * Preserve selected params * Fix multiple selection * Don't overflow on multiselect * Show tooltip on long values * Use different input for different types * Show all actions again * Move dsl editor to directive * Update filter query dsl editor * Clean up code * Move filter field select into own directive * Move filter operator select into own directive * Move utils to separate file * Move field options to field directive * Move operator options to operator directive * Move params under operator type * Move params editor into own directive * Move param editors to own directives * Don't highlight values * Don't use unnecessary onChange * Use text input if no suggestions * Remove unused updateFilter * Enhance params editors Move params editors to separate file and present different editors based on field type * Update save filter api * Update save filter api * Fix a couple tests * Fix more tests * Fix map phrase test * test cleanup * Hide editor on esc key * Use first index pattern if none specified * FilterEditorUtils test and fix range error * fix date phrase * Date format should allow date math values * Only show add filter button if there are index patterns * Look up field from indexPatterns service rather than passed index patterns * Use basepath instead of relative path * Feedback from bargs * Don't show filter bar when ya shouldnt * don't reload panel saved objects * Show date math instead of formatted date * Focus on params even when not ui-select * Hide editor on delete * Update styles to BEM format * Update styles * Add more tests * Don't show pin/disable * Fix bug where saving a filter edit without making changes messed up pinning * Update styles to camelcase * Fix cutoff from top of screen for ui-select * Add accessibility * Align to top * Align inputs and add placeholders * Dynamic input sizing * Fix dashboard panel test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #11375