[UI Framework] Add support for multi-line queries to LocalNavSearch component of UI Framework. #11975
Conversation
cjcenizal
added
Team:Platform-Design
cjcenizal
force-pushed
the
feature/expandable-local-nav-search
branch
from
c872ab5
to
9237e9e
Compare
|
CC @tbragin too As it's implemented now, how does it interact with the existing typeahead dropdown? Though when I said autocomplete, I was actually talking about this possible future state |
|
@cjcenizal is this the PR to follow for your phase 2 of #11972? @Bargs current behavior can be seen below. I'd almost expect something similar for this PR. Eventually it'd be nice to have the UX that you referenced or something more along the lines of console. |
|
@alexfrancoeur This PR is similar and the code originated in the Timelion PR, but for now I'm considering it a separate feature until we decide to move the Timelion input back into the LocalNav. |
|
@cjcenizal sounds good, please just tag me in the new PR for the additional UI enhancements. |
| @@ -0,0 +1,68 @@ | |||
| /* eslint-disable */ | |||
|
|
|||
| const $searchInput = $('#expandableSearchInput'); | |||
There was a problem hiding this comment.
Don't we want to provide the examples using React components?
|
This is on hold until we've figured out how it will interact with KQL (#12282). |
|
BTW @cjcenizal this is on my todo list to play with. Some of the geo queries can get quite large in Kuery so we'll definitely want multi line support. Not sure how soon I'll get to it, but it's on my mind :) |
|
Closing this for now. |
This code was cherry-picked from #11972.
One thing to consider is how this will interact with autocompletion suggestions, similar to what we encountered in Discover as part of #10928: