[APM] Reinstate ML multi-metric job #117836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgieselaar
added
release_note:enhancement
Team:APM
|
Pinging @elastic/apm-ui (Team:apm) |
smith
approved these changes
Nov 8, 2021
sorenlouv
reviewed
Nov 9, 2021
sorenlouv
approved these changes
Nov 9, 2021
x-pack/plugins/ml/server/models/data_recognizer/modules/apm_transaction/manifest.json
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/server/models/data_recognizer/modules/apm_transaction/ml/apm_metrics.json
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/server/models/data_recognizer/modules/apm_transaction/ml/apm_metrics.json
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/server/models/data_recognizer/modules/apm_transaction/ml/apm_metrics.json
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/server/models/data_recognizer/modules/apm_transaction/manifest.json
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/server/models/data_recognizer/modules/apm_transaction/ml/apm_metrics.json
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/server/models/data_recognizer/modules/apm_transaction/ml/apm_metrics.json
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/server/models/data_recognizer/modules/apm_transaction/ml/apm_metrics.json
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/server/models/data_recognizer/modules/apm_transaction/ml/apm_metrics.json
Outdated
Show resolved
Hide resolved
| "field" : "@timestamp" | ||
| } | ||
| }, | ||
| "transactions_per_min" : { |
There was a problem hiding this comment.
This will need changing to whatever is chosen for the field_name in the job config.
...lugins/ml/server/models/data_recognizer/modules/apm_transaction/ml/datafeed_apm_metrics.json
Outdated
Show resolved
Hide resolved
...lugins/ml/server/models/data_recognizer/modules/apm_transaction/ml/datafeed_apm_metrics.json
Outdated
Show resolved
Hide resolved
...lugins/ml/server/models/data_recognizer/modules/apm_transaction/ml/datafeed_apm_metrics.json
Outdated
Show resolved
Hide resolved
| { exists: { field: TRANSACTION_DURATION } }, | ||
| { term: { [PROCESSOR_EVENT]: ProcessorEvent.metric } }, | ||
| { term: { [METRICSET_NAME]: 'transaction' } }, | ||
| { terms: { _tier: ['content', 'hot', 'warm'] } }, |
There was a problem hiding this comment.
When the jobs are started from within the APM UI, what start time is used for the job? Unless you are running them over the full time range of data available, this _tier filter isn't needed. Assuming the start date is close to now, the time range part of the datafeed query will ensure the cold / frozen tiers won't be searched.
| { "term": { "processor.event": "transaction" } }, | ||
| { "exists": { "field": "transaction.duration" } } | ||
| { "term": { "processor.event": "metric" } }, | ||
| { "term": { "metricset.name": "transaction" } } |
There was a problem hiding this comment.
The manifest query will need to be
"query": {
"bool": {
"filter": [
{ "term": { "processor.event": "metric" } },
{ "term": { "metricset.name": "transaction" } }
],
"must_not": { "terms": { "_tier": [ "data_frozen", "data_cold" ] } }
}
},
but as discussed, feel free to leave the _tier part out of the changes in this PR and I can include them when editing all the other ML modules as part of #116696.
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
peteharverson
approved these changes
Nov 11, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 11, 2021
Closes elastic#101734. This reverts commit 008421f. Additionally, incorporate suggested changes from elastic#101734 (comment).
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Nov 11, 2021
claudiopro
pushed a commit
to claudiopro/kibana
that referenced
this pull request
Nov 11, 2021
Closes elastic#101734. This reverts commit 008421f. Additionally, incorporate suggested changes from elastic#101734 (comment).
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Nov 17, 2021
Closes elastic#101734. This reverts commit 008421f. Additionally, incorporate suggested changes from elastic#101734 (comment).
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
roeehub
pushed a commit
to build-security/kibana
that referenced
this pull request
Dec 16, 2021
Closes elastic#101734. This reverts commit 008421f. Additionally, incorporate suggested changes from elastic#101734 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #101734.
This reverts commit 008421f.
Additionally, incorporate suggested changes from #101734 (comment).