Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NA): fixes the creation of multiple processes at start #114940

Merged
merged 17 commits into from
Oct 15, 2021
Merged

fix(NA): fixes the creation of multiple processes at start #114940

merged 17 commits into from
Oct 15, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Oct 14, 2021 •
edited
Loading

[skip-ci]

This PR fixes the creation of multiple processes at start.

It does that by creating a no_transpilation_dist to be used when setting up the node env on production environments which allow us to not run the logic to add the development preserve-symlinks flag. As an end result it also avoids the creation of multiple processes when starting Kibana.

@mistic mistic requested a review from jbudz October 14, 2021 02:04
@mistic mistic added auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.15.2 v7.16.0 v8.0.0 labels Oct 14, 2021
@mistic mistic changed the title fix(NA): adds no_transpilation_dist to avoid preserve_symlinks on dist fix(NA): creation of multiple processes on production by splitting no_transpilation when setting up node env Oct 14, 2021
@mistic
Copy link
Member Author

mistic commented Oct 14, 2021

@elasticmachine merge upstream

@kibanamachine

This comment has been minimized.

Sign in to view
@mistic mistic marked this pull request as ready for review October 15, 2021 02:54
@mistic mistic requested a review from a team as a code owner October 15, 2021 02:54
jbudz
jbudz approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows LGTM

@mistic
Copy link
Member Author

mistic commented Oct 15, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 5fcc118 into elastic:master Oct 15, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 15, 2021
@mistic @kibanamachine
fix(NA): creation of multiple processes on production by splitting no…
8350343 
…_transpilation when setting up node env (elastic#114940)

* fix(NA): adds no_transpilation_dist to avoid preserve_symlinks on dist

* chore(NA): setup node env correctly on functional tests

* chore(NA): try to fix tests

* chore(NA): correctly separate split

* chore(NA): check ensure preserve symlinks need

* chore(NA): investigate path resolve result

* chore(NA): investigate path resolve result elastic#2

* chore(NA): comment out preserve symlinks

* chore(NA): apply fs.realpathSync into the calculated REPO_ROOT paths on babel_register_for_test_plugins

* chore(NA): removes debug code

* chore(NA): move array definition

* chore(NA): correctly import fs

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Oct 15, 2021
Closed
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 15, 2021
@mistic @kibanamachine
fix(NA): creation of multiple processes on production by splitting no…
c363508 
…_transpilation when setting up node env (elastic#114940)

* fix(NA): adds no_transpilation_dist to avoid preserve_symlinks on dist

* chore(NA): setup node env correctly on functional tests

* chore(NA): try to fix tests

* chore(NA): correctly separate split

* chore(NA): check ensure preserve symlinks need

* chore(NA): investigate path resolve result

* chore(NA): investigate path resolve result elastic#2

* chore(NA): comment out preserve symlinks

* chore(NA): apply fs.realpathSync into the calculated REPO_ROOT paths on babel_register_for_test_plugins

* chore(NA): removes debug code

* chore(NA): move array definition

* chore(NA): correctly import fs

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Oct 15, 2021
Closed
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x
✅ 7.15

The backport PRs will be merged automatically after passing CI.

mistic added a commit that referenced this pull request Oct 15, 2021
@mistic
Revert "fix(NA): creation of multiple processes on production by spli…
47ce4a8 
…tting no_transpilation when setting up node env (#114940)"

This reverts commit 5fcc118.
@mistic
Copy link
Member Author

mistic commented Oct 15, 2021

I had the need to revert this as somehow it doesn't work on Jenkins..Will re-open again and keep working on it

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 114940 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 19, 2021
@jbudz jbudz removed the release_note:skip Skip the PR/issue when compiling release notes label Oct 19, 2021
artem-shelkovnikov pushed a commit to artem-shelkovnikov/kibana that referenced this pull request Oct 20, 2021
@mistic @kibanamachine @artem-shelkovnikov
fix(NA): creation of multiple processes on production by splitting no…
3f2a531 
…_transpilation when setting up node env (elastic#114940)

* fix(NA): adds no_transpilation_dist to avoid preserve_symlinks on dist

* chore(NA): setup node env correctly on functional tests

* chore(NA): try to fix tests

* chore(NA): correctly separate split

* chore(NA): check ensure preserve symlinks need

* chore(NA): investigate path resolve result

* chore(NA): investigate path resolve result elastic#2

* chore(NA): comment out preserve symlinks

* chore(NA): apply fs.realpathSync into the calculated REPO_ROOT paths on babel_register_for_test_plugins

* chore(NA): removes debug code

* chore(NA): move array definition

* chore(NA): correctly import fs

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
artem-shelkovnikov pushed a commit to artem-shelkovnikov/kibana that referenced this pull request Oct 20, 2021
@mistic @artem-shelkovnikov
Revert "fix(NA): creation of multiple processes on production by spli…
dbb2502 
…tting no_transpilation when setting up node env (elastic#114940)"

This reverts commit 5fcc118.
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 114940 or prevent reminders by adding the backport:skip label.

@mistic mistic added the backport:skip This commit does not require backporting label Oct 20, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 20, 2021
@mgevans-5
Copy link

hi folks - do we have documentation on how to use this? A link would be great

Also the release notes for Kibana 7.15.2 seem to conflict with the initial statement - or one or the other notes isn't clear to me.

From release notes: https://www.elastic.co/guide/en/kibana/7.15/release-notes-7.15.2.html

Operations
Adds ability to create multiple processes on production by splitting no_transpilation when setting up node env #114940

From this issue description

This PR creates a no_transpilation_dist to be used when setting up the node env on production environments
which allow us to not run the logic to add the development preserve-symlinks flag.
As an end result it also avoids the creation of multiple processes when starting Kibana.

any clarity would be great - thanks!

@mistic mistic changed the title fix(NA): creation of multiple processes on production by splitting no_transpilation when setting up node env fix(NA): fixes the creation of multiple processes on production by splitting no_transpilation when setting up node env Nov 11, 2021
@mistic
Copy link
Member Author

mistic commented Nov 11, 2021 •
edited
Loading

@mgevans-5 I've made the title and the description of the PR more clear as well as updated the labels. Will follow up on updating the release notes.

This PR fixes a bug indeed. Previously we let a development need on preserve symlinks to slip into dist code which end up creating two processes, which is not the case anymore.

Thanks for letting us know about this 👍

@mistic mistic mentioned this pull request Nov 11, 2021
Merged
@mistic mistic changed the title fix(NA): fixes the creation of multiple processes on production by splitting no_transpilation when setting up node env fix(NA): fixes the creation of multiple processes at start Nov 11, 2021
@mistic
Copy link
Member Author

mistic commented Nov 11, 2021 •
edited
Loading

Follow up: the release notes for v7.15.2 were updated which should be reflected in the official publish soon! #118387

@jbudz jbudz mentioned this pull request Dec 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting buildkite-ci chore release_note:fix Team:Operations Team label for Operations Team v7.15.2 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mistic @kibanamachine @elasticmachine @mgevans-5 @jbudz @KOTungseth