Removes unused and renamed deprecated core settings and deprecated settings from core plugins #113653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_frequency_millis
…nd cpuacct.cgroup.path.override
…igs to use server.xsrf.allowlist instead
TinaHeiligers
added
release_note:breaking
v8.0.0
backport:skip
|
Pinging @elastic/kibana-core (Team:Core) |
jbudz
approved these changes
Oct 1, 2021
TinaHeiligers
commented
Oct 1, 2021
| @@ -16,18 +16,22 @@ function collectDeprecations( | |||
| ) { | |||
| const deprecations = provider(configDeprecationFactory); | |||
| const deprecationMessages: string[] = []; | |||
| const deprecationLevels: string[] = []; | |||
There was a problem hiding this comment.
Needed to test changing the rewriteCorsSetting level from critical to warning.
TinaHeiligers
commented
Oct 1, 2021
| @@ -39,23 +39,4 @@ export type BannersConfigType = TypeOf<typeof configSchema>; | |||
| export const config: PluginConfigDescriptor<BannersConfigType> = { | |||
| schema: configSchema, | |||
| exposeToBrowser: {}, | |||
| deprecations: () => [ | |||
There was a problem hiding this comment.
The unit tests only tested deprecations.
TinaHeiligers
commented
Oct 1, 2021
| @@ -364,4 +364,34 @@ Configuration management tools and automation will need to be updated to use the | |||
| === `server.xsrf.token` is no longer valid | |||
| *Details:* The deprecated `server.xsrf.token` setting in the `kibana.yml` file has been removed. | |||
|
|
|||
| [float] | |||
There was a problem hiding this comment.
I only added breaking changes for the settings that are documented.
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
jonathan-buttner
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #103915
Currently blocked by https://github.com/elastic/cloud/issues/89185 (for settings handled in this PR).To reviewers:
If your team was pinged it means we needed to update one or more files in your domain.
Please filter the files and review changes that needed to be made.
Core team: There will be follow up PRs to handle the remaining core deprecations as these will likely require some further discussion.
During the 7 series, we added deprecations for configuration settings that were going to be removed in 8.0.
This PR removes support for the following configuration settings and adds documentation on breaking changes as needed:
newsfeed.defaultLanguagexpack.banners.placementcpu.cgroup.path.overrideops.cGroupOverrides.cpuPathcpuacct.cgroup.path.overrideops.cGroupOverrides.cpuAcctPathserver.xsrf.whitelistserver.xsrf.allowlistKIBANA_PATH_CONFKBN_PATH_CONFkibana.disableWelcomeScreenhome.disableWelcomeScreenui_metric.enabledusageCollection.uiCounters.enabledui_metric.debugusageCollection.uiCounters.debugusageCollection.uiMetric.enabledusageCollection.uiCounters.enabledusageCollection.uiMetric.debugusageCollection.uiCounters.debugxpack.xpack_main.xpack_api_polling_frequency_millisxpack.licensing.api_polling_frequencyAdditional changes:
server.corsdeprecation remains but changed fromlevel:criticaltolevel:warningon recommendation from @kibana-securityChecklist
(https://github.com/elastic/kibana/blob/master/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
For maintainers
Release note:
The deprecation notice for
server.corshas changed fromlevel:criticaltolevel:warning.Support for the following deprecated configuration settings has been removed:
newsfeed.defaultLanguageis no longer used. Newsfeed items will be retrieved based on the browser locale and default to English.xpack.banners.placementhas changed value from 'header' to 'top'cpu.cgroup.path.overrideis no longer valid and has been replaced withops.cGroupOverrides.cpuPathcpuacct.cgroup.path.overrideis no longer valid and has been replaced withops.cGroupOverrides.cpuAcctPathserver.xsrf.whitelistis no longer valid and has been replaced withserver.xsrf.allowlistxpack.xpack_main.xpack_api_polling_frequency_millisis no longer valid and has been replace withxpack.licensing.api_polling_frequencyKIBANA_PATH_CONFis no longer valid. Going forward, set the path to the Kibana configuration file using theKBN_PATH_CONFenvironment variable.