Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Make Formula functional tests less flaky #112428

Merged
merged 4 commits into from
Sep 20, 2021
Merged

[Lens] Make Formula functional tests less flaky #112428

merged 4 commits into from
Sep 20, 2021

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Sep 16, 2021

Summary

Fixes (again) #102183

Adding some waiting time after the typing fixed the flaky behaviour - the editor schedules a text replacement as async task and sometimes it takes a bit longer than usual.

Here I've ran the lens formula suite with 100 agents: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1902/

Checklist

Delete any items that are not applicable to this PR.

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Sep 16, 2021
@dej611 dej611 requested a review from a team as a code owner September 16, 2021 14:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

@jbudz
Copy link
Member

jbudz commented Sep 16, 2021

Can we backport to 7.14+? Here's a recent failure:
https://buildkite.com/elastic/kibana-elasticsearch-snapshot-verify/builds/119#_

@dej611
Copy link
Contributor Author

dej611 commented Sep 20, 2021

@elasticmachine merge upstream

@dej611
Copy link
Contributor Author

dej611 commented Sep 20, 2021

Can we backport to 7.14+? Here's a recent failure:
buildkite.com/elastic/kibana-elasticsearch-snapshot-verify/builds/119#_

I see no harm in that. What do you think @stratoula @flash1293 ?

@stratoula
Copy link
Contributor

Yes it is fine. For functional tests fixes it is safe to backport them in previous versions

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611
Copy link
Contributor Author

dej611 commented Sep 20, 2021

Changed labels to enable backports to 7.14+

mbondyra
mbondyra approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm, not sure if it will help avoiding flakiness completely, but definitely will not harm anything!

@dej611 dej611 merged commit 298de06 into elastic:master Sep 20, 2021
@dej611 dej611 deleted the fix/102183-3 branch September 20, 2021 13:56
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 20, 2021
@dej611 @kibanamachine
[Lens] Make Formula functional tests less flaky (elastic#112428)
47e987e 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Sep 20, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 20, 2021
@dej611 @kibanamachine
[Lens] Make Formula functional tests less flaky (elastic#112428)
ab8e1fc 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Sep 20, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 20, 2021
@dej611 @kibanamachine
[Lens] Make Formula functional tests less flaky (elastic#112428)
ec85a5b 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Sep 20, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x
✅ 7.14
✅ 7.15

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 20, 2021
@kibanamachine @dej611
[Lens] Make Formula functional tests less flaky (#112428) (#112560)
da37f49 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Sep 20, 2021
@kibanamachine @dej611
[Lens] Make Formula functional tests less flaky (#112428) (#112559)
24b58a6 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Sep 20, 2021
@kibanamachine @dej611
[Lens] Make Formula functional tests less flaky (#112428) (#112561)
e8d2ffc 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.2 v7.15.1 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dej611 @elasticmachine @jbudz @stratoula @kibanamachine @mbondyra