Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0] Remove legacy logging #112305
[8.0] Remove legacy logging #112305
Changes from all commits
eb6d618
0771036
7bae5e5
7b8aeb5
3e5c71a
1ca0080
2aa840b
0d8b958
6b25dde
cf931a4
a1a1568
25460af
32bbc99
b6f7cfd
5d2c1cc
f13bc1f
4d7927f
afabe9e
d7cc6e7
db4edaa
fb4ff9e
e4aac52
f1a5814
2fe5a24
1b7ff38
8c0d873
e1d6174
78d5560
11131d4
2da87f6
14be47f
abd2e6f
7c978a6
c09776d
67ce208
b33664b
2188399
48efa70
3e34e23
f41b60b
234f4fb
4957cd0
d97156c
bd20385
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elastic/kibana-operations I kept the property in the
Optimizer
options and just set it to false to avoid more downstream changes. This can eventually be cleaned up as a follow-up (unless we really want to do it in current PR).Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't sure if I should keep
silent
andverbose
inCliArgs
. Those are effectively unused insidecore
, as now their only usages is to changelogging.root.level
fromsrc/cli/serve/serve.js
, but at the same times, they're still cli args, so we may want to have them propagated to core for telemetry of some other need. WDYT?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know how many users rely on
silent
andverbose
cli flags? What bothers me is that we allow using them asCLI flags
but not as config values. Btw we need to replace all thelogging.*
values inkibana.yml
with their Kibana Logging system counterparts.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this bugs me too -- IIRC when we had last discussed this (I think with @spalger ?), the case was made that configuring appenders via the CLI is more cumbersome than when working in the yaml, and that it was a minimal maintenance burden to keep
silent
andverbose
in place, which is why we only deprecatedquiet
at the time.