Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[config] Remove deprecated environment variables CONFIG_PATH and DATA_PATH #111535

Merged
merged 3 commits into from
Sep 9, 2021
Merged

[config] Remove deprecated environment variables CONFIG_PATH and DATA_PATH #111535

merged 3 commits into from
Sep 9, 2021

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Sep 8, 2021

Related to #103915

Release note
Removed environment variables CONFIG_PATH and DATA_PATH. Use the environment variable KBN_PATH_CONF instead of CONFIG_PATH. Use the setting path.data instead of DATA_PATH.

@jbudz jbudz added release_note:breaking Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team v8.0.0 backport:skip This commit does not require backporting labels Sep 8, 2021
@jbudz jbudz requested review from a team as code owners September 8, 2021 14:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@jbudz jbudz mentioned this pull request Sep 8, 2021
Closed
@tylersmalley
Copy link
Contributor

@jbudz can you look into adding this to the Core Deprecation Service for use with the Upgrade Assistant? https://github.com/elastic/kibana/tree/master/src/core/server/deprecations

This was referenced Sep 8, 2021
Closed
Merged
@pgayvallet
Copy link
Contributor

pgayvallet commented Sep 9, 2021 •
edited
Loading

can you look into adding this to the Core Deprecation Service for use with the Upgrade Assistant?

All config deprecations are automatically added to the deprecations used by UA. As long as this PR lands in 8.0 only, I don't think there's anything more to be done?

pgayvallet
pgayvallet approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core changes LGTM

@jbudz
Copy link
Member Author

jbudz commented Sep 9, 2021

I verified these settings are in the upgrade assistant when used in 7.x:
image

~/dev/kibana-7.x(7.x) » DATA_PATH=$(pwd)/data CONFIG_PATH=$(pwd)/config/kibana.yml yarn start

@jbudz jbudz enabled auto-merge (squash) September 9, 2021 21:50
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz merged commit 5763a2f into elastic:master Sep 9, 2021
@TinaHeiligers
Copy link
Contributor

@jbudz Now that these are exposed to the upgrade assistant, can we go ahead with removing them from core deprecations for 8.0?.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:breaking Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jbudz @elasticmachine @tylersmalley @pgayvallet @kibanamachine @TinaHeiligers