Migrate es_archives/lens/basic/ to kbnArchiver #108120

bhavyarm · 2021-08-10T22:08:26Z

This is part 1 of migrating lens .kibana esArchiver to kbnArchiver.

elasticmachine · 2021-08-10T22:08:28Z

Pinging @elastic/kibana-qa (Team:QA)

bhavyarm · 2021-08-11T13:59:12Z

@elasticmachine merge upstream

bhavyarm · 2021-08-12T14:06:14Z

@elasticmachine merge upstream

bhavyarm · 2021-08-13T14:13:06Z

Keeps passing in my local.

bhavyarm · 2021-08-13T14:13:15Z

@elasticmachine merge upstream

LeeDr

Without fully investigating and debugging why the timepicker didn't get set correctly, the changes I've proposed here should resolve the problem by setting the default time to the same as the time we would set the timepicker to. It shouldn't hurt at all if the timepicker is still set, but you could potentially remove all those calls (at least in the ones the failed in Jenkins like kibana/x-pack/test/functional/apps/lens/smokescreen.ts) and the test will be faster.

LeeDr · 2021-08-19T19:04:10Z

x-pack/test/functional/apps/lens/index.ts

-      await esArchiver.load('x-pack/test/functional/es_archives/lens/basic');
+      await kibanaServer.importExport.load(
+        'x-pack/test/functional/fixtures/kbn_archiver/lens/lens_basic.json'
+      );


The test failure on the last run and it's screenshot, shows that for some reason the end time in the timepicker didn't get set to the required date/time (in this file kibana/x-pack/test/functional/apps/lens/smokescreen.ts);

✖ fail: lens app lens smokescreen tests should create a pie chart and switch to datatable │ Error: expected '@timestamp per 30 days' to sort of equal '@timestamp per 3 hours' │ + expected - actual │ │ -@timestamp per 30 days │ +@timestamp per 3 hours

I thought about adding code in the time_picker page object method setAbsoluteTimeRange (sp?) to check that it actually did get the time set correctly. But decided instead to suggest this change to make the tests faster by setting the default time for the timepicker. This eliminates the need to call PageObjects.lens.goToTimeRange()

Suggested change

);

);

// changing the timepicker default here saves us from having to set it in Discover (~8s)

await PageObjects.timePicker.setDefaultAbsoluteRangeViaUiSettings();

await kibanaServer.uiSettings.update({'dateFormat:tz': 'UTC', });

Using the timepicker here requires a couple other changes;

diff --git a/x-pack/test/functional/apps/lens/index.ts b/x-pack/test/functional/apps/lens/index.ts index 0c3cbce23bd..7b26640738b 100644 --- a/x-pack/test/functional/apps/lens/index.ts +++ b/x-pack/test/functional/apps/lens/index.ts @@ -7,20 +7,24 @@ import { FtrProviderContext } from '../../ftr_provider_context'; -export default function ({ getService, loadTestFile }: FtrProviderContext) { +export default function ({ getService, loadTestFile, getPageObjects }: FtrProviderContext) { const browser = getService('browser'); const log = getService('log'); const esArchiver = getService('esArchiver'); const kibanaServer = getService('kibanaServer'); + const PageObjects = getPageObjects(['timePicker',]); describe('lens app', () => { before(async () => { log.debug('Starting lens before method'); await browser.setWindowSize(1280, 800); - await esArchiver.load('x-pack/test/functional/es_archives/logstash_functional'); + await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/logstash_functional'); await kibanaServer.importExport.load( 'x-pack/test/functional/fixtures/kbn_archiver/lens/lens_basic.json' ); + // changing the timepicker default here saves us from having to set it in Discover (~8s) + await PageObjects.timePicker.setDefaultAbsoluteRangeViaUiSettings(); + await kibanaServer.uiSettings.update({'dateFormat:tz': 'UTC', }); }); after(async () => { @@ -28,6 +32,7 @@ export default function ({ getService, loadTestFile }: FtrProviderContext) { await kibanaServer.importExport.unload( 'x-pack/test/functional/fixtures/kbn_archiver/lens/lens_basic.json' ); + await PageObjects.timePicker.resetDefaultAbsoluteRangeViaUiSettings(); }); describe('', function () {

also note that a couple of lens tests load other esArchives, which wipes out the defaultTime setting change made in the lens/index file. So if you wanted to remove the calls to the timepicker in those tests, you would have to add the call to
await PageObjects.timePicker.setDefaultAbsoluteRangeViaUiSettings(); in those tests after the esArchive load.

LeeDr · 2021-08-19T19:12:24Z

x-pack/test/functional/apps/lens/index.ts

-      await esArchiver.unload('x-pack/test/functional/es_archives/lens/basic');
+      await kibanaServer.importExport.unload(
+        'x-pack/test/functional/fixtures/kbn_archiver/lens/lens_basic.json'
+      );


As noted in the comment above, make sure to reset the default time in the after method;

await PageObjects.timePicker.resetDefaultAbsoluteRangeViaUiSettings();

bhavyarm · 2021-08-20T18:10:16Z

@elasticmachine merge upstream

bhavyarm · 2021-08-20T19:48:44Z

@elasticmachine merge upstream

x-pack/test/functional/apps/dashboard/dashboard_maps_by_value.ts

x-pack/test/functional/apps/dashboard/dashboard_tagging.ts

x-pack/test/functional/page_objects/lens_page.ts

…he test is run

bhavyarm · 2021-11-02T15:55:44Z

@elasticmachine merge upstream

bhavyarm · 2021-11-02T16:07:41Z

@elasticmachine merge upstream

mbondyra · 2021-11-02T16:10:06Z

x-pack/test/functional/apps/lens/table.ts

@@ -56,17 +57,19 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
    });

    it('should allow to configure column visibility', async () => {
+      screenshot.take('toggleColumnVisibility0: before');


these and the x-pack/test/functional/page_objects/lens_page.ts screenshots are to be removed right? I think I left it there 🙈

aww we were happy about them. Thank you again for all that you did for this maddening frustrating pr @mbondyra you rock!

mbondyra

I've removed the screenshots I've added before so make sure pull the changes :) This is an enormous effort and thank you for it @bhavyarm, I have no remarks about the code and I'll approve as soon as the CI tests pass 🤞🏼

LeeDr

LGTM

mbondyra · 2021-11-03T12:37:06Z

Looks like flaky test runner doesn't work as expected not only for your branch but even for main. So your PR looks good to me! Approved :)

mbondyra · 2021-11-03T12:41:02Z

One more thing - please be cautious when merging it to 7.16 - there is one unmerged PR in the past that can cause conflicts here. The mentioned PR was causing failures for 7.16 even though the change seems irrelevant (changing CI groups to balance functional tests) and that's why it wasn't merged to 7.16. There's a chance this PR can cause the same so let's keep an eye on it. :)

bhavyarm · 2021-11-03T13:19:15Z

Thank you @mbondyra @LeeDr for your awesome rockstar support!

bhavyarm · 2021-11-03T13:19:37Z

@elasticmachine merge upstream

kibanamachine · 2021-11-03T15:16:08Z

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

💚 Build #3721 succeeded 9df8831
💔 Build #3704 failed b2a5827
💛 Build #3581 was flaky 438636e
💚 Build #3191 succeeded 8f20652
💚 Build #2788 succeeded 722ce4a
💔 Build #2024 failed ac9fbdb

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

kibanamachine · 2021-11-03T15:23:09Z

💔 Backport failed

Status	Branch	Result
✅	8.0
❌	7.16	Commit could not be cherrypicked due to conflicts

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 108120

Co-authored-by: Bhavya RM <bhavya@elastic.co>

# Conflicts: # x-pack/test/api_integration/apis/lens/telemetry.ts # x-pack/test/functional/es_archives/lens/basic/mappings.json

bhavyarm added 3 commits August 10, 2021 17:47

migrate lens/basic kibana esArchiver to kbnArchiver

ce9e21a

x-pack/test/functional/apps/lens/index.ts

f3a3fea

Merge branch 'master' into lensKbnArchiver

6018f99

bhavyarm added Team:QA Team label for QA Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Aug 10, 2021

bhavyarm self-assigned this Aug 10, 2021

replacing esArchiver/lens/basic with kbnArchiver/lens/basic

318a9d9

bhavyarm requested a review from a team as a code owner August 11, 2021 13:56

fixing type errors

201a89a

bhavyarm force-pushed the lensKbnArchiver branch from 2014ef7 to 201a89a Compare August 11, 2021 14:37

Merge branch 'master' into lensKbnArchiver

7c64b51

mistic added v7.16.0 and removed v7.15.0 labels Aug 18, 2021

LeeDr suggested changes Aug 19, 2021

View reviewed changes

bhavyarm added 2 commits August 20, 2021 13:01

Merge branch 'master' into lensKbnArchiver

5e16bb5

making timepicker changes for index.ts

fef00ed

bhavyarm force-pushed the lensKbnArchiver branch from 6f757aa to fef00ed Compare August 20, 2021 18:09

fixing typo

e0a489d

bhavyarm force-pushed the lensKbnArchiver branch from e28ecd6 to e0a489d Compare August 20, 2021 19:48

LeeDr reviewed Nov 2, 2021

View reviewed changes

x-pack/test/functional/apps/dashboard/dashboard_maps_by_value.ts Show resolved Hide resolved

LeeDr reviewed Nov 2, 2021

View reviewed changes

x-pack/test/functional/apps/dashboard/dashboard_tagging.ts Show resolved Hide resolved

LeeDr reviewed Nov 2, 2021

View reviewed changes

x-pack/test/functional/page_objects/lens_page.ts Show resolved Hide resolved

adding savedObjects.clean to clean up straggler saved objects after t…

b036aca

…he test is run

Merge branch 'main' into lensKbnArchiver

b2a5827

Merge branch 'main' into lensKbnArchiver

1c6864f

mbondyra reviewed Nov 2, 2021

View reviewed changes

mbondyra added 2 commits November 2, 2021 17:11

Update table.ts

782f39a

Update lens_page.ts

9df8831

mbondyra reviewed Nov 2, 2021

View reviewed changes

LeeDr approved these changes Nov 2, 2021

View reviewed changes

mbondyra approved these changes Nov 3, 2021

View reviewed changes

Merge branch 'main' into lensKbnArchiver

ea64daa

LeeDr added the v8.1.0 label Nov 3, 2021

bhavyarm merged commit 9c98c2b into elastic:main Nov 3, 2021

kibanamachine mentioned this pull request Nov 3, 2021

[8.0] Migrate es_archives/lens/basic/ to kbnArchiver (#108120) #117345

Merged

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 3, 2021

Migrate es_archives/lens/basic/ to kbnArchiver (elastic#108120)

545e7f3

kibanamachine added a commit that referenced this pull request Nov 3, 2021

Migrate es_archives/lens/basic/ to kbnArchiver (#108120) (#117345)

4070342

Co-authored-by: Bhavya RM <bhavya@elastic.co>

bhavyarm mentioned this pull request Nov 5, 2021

[7.16] Migrate es_archives/lens/basic/ to kbnArchiver (#108120) #117650

Closed

bhavyarm added a commit to bhavyarm/kibana that referenced this pull request Nov 5, 2021

Migrate es_archives/lens/basic/ to kbnArchiver (elastic#108120)

15cd891

# Conflicts: # x-pack/test/api_integration/apis/lens/telemetry.ts # x-pack/test/functional/es_archives/lens/basic/mappings.json

LeeDr mentioned this pull request Mar 17, 2022

[meta] Migrate .kibana esArchives to kbnArchiver #102552

Closed

LeeDr removed the v7.16.0 label Mar 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate es_archives/lens/basic/ to kbnArchiver #108120

Migrate es_archives/lens/basic/ to kbnArchiver #108120

bhavyarm commented Aug 10, 2021

elasticmachine commented Aug 10, 2021

bhavyarm commented Aug 11, 2021

bhavyarm commented Aug 12, 2021

bhavyarm commented Aug 13, 2021

bhavyarm commented Aug 13, 2021

LeeDr left a comment •

edited

Loading

LeeDr Aug 19, 2021

LeeDr Aug 19, 2021

LeeDr Aug 19, 2021

LeeDr Aug 19, 2021

bhavyarm commented Aug 20, 2021

bhavyarm commented Aug 20, 2021

bhavyarm commented Nov 2, 2021

bhavyarm commented Nov 2, 2021

mbondyra Nov 2, 2021

bhavyarm Nov 2, 2021

mbondyra left a comment

LeeDr left a comment

mbondyra commented Nov 3, 2021

mbondyra commented Nov 3, 2021

bhavyarm commented Nov 3, 2021

bhavyarm commented Nov 3, 2021

kibanamachine commented Nov 3, 2021

kibanamachine commented Nov 3, 2021

-      );
+      );
+      // changing the timepicker default here saves us from having to set it in Discover (~8s)
+      await PageObjects.timePicker.setDefaultAbsoluteRangeViaUiSettings();
+      await kibanaServer.uiSettings.update({'dateFormat:tz': 'UTC', });

Migrate es_archives/lens/basic/ to kbnArchiver #108120

Migrate es_archives/lens/basic/ to kbnArchiver #108120

Conversation

bhavyarm commented Aug 10, 2021

elasticmachine commented Aug 10, 2021

bhavyarm commented Aug 11, 2021

bhavyarm commented Aug 12, 2021

bhavyarm commented Aug 13, 2021

bhavyarm commented Aug 13, 2021

LeeDr left a comment • edited Loading

Choose a reason for hiding this comment

LeeDr Aug 19, 2021

Choose a reason for hiding this comment

LeeDr Aug 19, 2021

Choose a reason for hiding this comment

LeeDr Aug 19, 2021

Choose a reason for hiding this comment

LeeDr Aug 19, 2021

Choose a reason for hiding this comment

bhavyarm commented Aug 20, 2021

bhavyarm commented Aug 20, 2021

bhavyarm commented Nov 2, 2021

bhavyarm commented Nov 2, 2021

mbondyra Nov 2, 2021

Choose a reason for hiding this comment

bhavyarm Nov 2, 2021

Choose a reason for hiding this comment

mbondyra left a comment

Choose a reason for hiding this comment

LeeDr left a comment

Choose a reason for hiding this comment

mbondyra commented Nov 3, 2021

mbondyra commented Nov 3, 2021

bhavyarm commented Nov 3, 2021

bhavyarm commented Nov 3, 2021

kibanamachine commented Nov 3, 2021

💚 Build Succeeded

Metrics [docs]

History

kibanamachine commented Nov 3, 2021

💔 Backport failed

LeeDr left a comment •

edited

Loading