[FieldFormats] Unskip url field formatter test #107651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dosant
commented
Aug 4, 2021
| await settings.setFieldFormat('url'); | ||
| await settings.controlChangeSave(); | ||
| }); | ||
|
|
||
| it('applied on dashboard', async () => { | ||
| await common.navigateToApp('dashboard'); | ||
| await dashboard.loadSavedDashboard('dashboard with everything'); | ||
| await dashboard.loadSavedDashboard('dashboard with table'); |
There was a problem hiding this comment.
Looks like the test was flaky because this dashboard was flaky to load (too many panels?)
as a fix, I am adding a single-purpose dashboard as this test focuses on URL field format. This dashboard should be more stable
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
Dosant
added
Feature:FieldFormatters
release_note:skip
Dosant
changed the title
Dosant
added
the
auto-backport
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
poffdeluxe
approved these changes
Aug 4, 2021
mattkime
approved these changes
Aug 4, 2021
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Aug 5, 2021
streamich
pushed a commit
to vadimkibana/kibana
that referenced
this pull request
Aug 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close #79463
flaky test runner: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1800/ - success in 42 runs
Part of working on improving ff tests: #59567