[Archive Migration] x-pack..discover/feature_controls/spaces #107644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wayneseymour
added
v8.0.0
release_note:skip
Add archive with space and one w/o, use them. Drop use of no longer needed es archive.
wayneseymour
force-pushed
the
esarchiver-migration/xpack-discover-feature-controls-spaces
branch
from
7bea3ad
to
99b5d75
Compare
|
Gonna try without the old config object. |
Based on a conversation with Lee, I'm going to try to get it to pass w/o the older config object. He mentioned that he noticed it assigns a default index pattern, but this assigned default index pattern does not actually show up in the ui, nor does it throw an error.
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
wayneseymour
deleted the
esarchiver-migration/xpack-discover-feature-controls-spaces
branch
💔 Backport failed
To backport manually run: |
wayneseymour
added a commit
to wayneseymour/kibana
that referenced
this pull request
Aug 11, 2021
…#107644) # Conflicts: # x-pack/test/functional/es_archives/discover/feature_controls/spaces/mappings.json
wayneseymour
added a commit
that referenced
this pull request
Aug 11, 2021
#108157) # Conflicts: # x-pack/test/functional/es_archives/discover/feature_controls/spaces/mappings.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete
x-pack/test/functional/es_archives/discover/feature_controls/spaces/*.Add
x-pack/test/functional/fixtures/kbn_archiver/discover/feature_controls/custom_space.json.Add
x-pack/test/functional/fixtures/kbn_archiver/discover/feature_controls/space.json.Update tests to use the newly added archives.