[Telemetry] Add telemetry.sendUsageTo config #107396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bamieh
added
v8.0.0
release_note:skip
afharo
approved these changes
Aug 5, 2021
|
|
||
| it('sets "telemetryConfig.sendUsageTo: prod" if "telemetry.url" uses the non-staging endpoint', () => { | ||
| const rawConfig = createMockRawConfig({ | ||
| url: 'random-endpoint', |
There was a problem hiding this comment.
optional: should we add a warning in this case?
Something like Dismissing random-endpoint, and using Elastic's production URL.
| statsGetterConfig | ||
| ).catch((err) => { | ||
| // The server is likely behind a firewall and can't reach the remote service | ||
| logger.warn( | ||
| `Failed to notify "${optInStatusUrl}" from the server about the opt-in selection. Possibly blocked by a firewall? - Error: ${err.message}` | ||
| `Failed to notify the telemetry endpoint about the opt-in selection. Possibly blocked by a firewall? - Error: ${err.message}` |
There was a problem hiding this comment.
NIT: I'd detail the URL here. If an admin finds this message annoying, they have the details in the error to fix the firewall rules.
There was a problem hiding this comment.
It is shown first this in the err payload so I removed it.
There was a problem hiding this comment.
Oh! In that case, please dismiss the comment :)
⏳ Build in-progress, with failures
History
To update your PR or re-run it, just comment with: |
jbudz
approved these changes
Aug 5, 2021
Bamieh
added a commit
that referenced
this pull request
Aug 5, 2021
streamich
pushed a commit
to vadimkibana/kibana
that referenced
this pull request
Aug 8, 2021
This was referenced Oct 13, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft until CI passes and I self-review the code.
telemetry.sendUsageTo: staging | prodto allow specifying which telemetry endpoint the cluster should be reporting to. This is only needed for testing clusters and other internal Elastic uses cases.Deprecation notice will appear in addition to automatically updating
telemetry.sendUsageToif the url is pointing to staging.telemetry.url.telemetry.optInStatusUrl.getTelemetryChannelEndpointcommon function. This is inline with the other config getters we have in the common file.Closes #96761