[TSVB] Adds a color picker in percentiles and percentiles rank aggs #107390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
stratoula
changed the title
stratoula
changed the title
stratoula
added
Feature:TSVB
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
mbondyra
approved these changes
Aug 11, 2021
...s/vis_type_timeseries/public/application/components/aggs/percentile_rank/multi_value_row.tsx
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Aug 12, 2021
…lastic#107390) * WIP - Improve the way that percentiles are rendered in TSVB * Adds color picker to percentile and percentile ranks * initialize color * Be backwards compatible * Fixes unit tests * Add a unit test for percentile rank * Fix unit tests * Address PR comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
stratoula
added a commit
that referenced
this pull request
Aug 12, 2021
…107390) (#108357) * WIP - Improve the way that percentiles are rendered in TSVB * Adds color picker to percentile and percentile ranks * initialize color * Be backwards compatible * Fixes unit tests * Add a unit test for percentile rank * Fix unit tests * Address PR comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #102325
It adds the color picker on percentiles and percentiles_rank aggregations to give the users the ability to change the percentiles series color. This will make the percentiles created to be more readable.
The color picker is visible only for timeseries, gauge and topN charts and only when the series is grouped by
everything.If it is grouped by terms or filters it follows its color rules.
I also moved the percent in the front of the legend in order to be more easy to distinguish it as usually the legends for these aggregations are quite long. This will be improved when this will be merged and applied to kibana.
Checklist