-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include upcoming default values for the session timeouts in the deprecation log. #106673
Include upcoming default values for the session timeouts in the deprecation log. #106673
Conversation
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
Pinging @elastic/kibana-security (Team:Security) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! question do you think we should merge into master
as well, so that the config_deprecations
file is kept in sync between the branches? At some point master
will diverge to support 8.0
, but it might make maintaining these deprecations easier in the short term if everything is aligned
I was considering this initially, but the issue is that this deprecation will always be logged in master/8.0 if we keep it (raw session settings will be |
Ah good call, I forgot about that the deprecations run beforehand. In that case, I'm happy to leave this as-is, and only merge into |
Summary
Include upcoming default values for the session timeouts in the deprecation log.
Follow-up for: #106061