Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Localization] postfix ids with .markdown #104062

Merged
merged 4 commits into from
Jul 3, 2021
Merged

[Localization] postfix ids with .markdown #104062

merged 4 commits into from
Jul 3, 2021

Conversation

Bamieh
Copy link
Member

@Bamieh Bamieh commented Jul 1, 2021

We need to postfix the ids of all i18n messages containing markdown with .markdown to enable our automation to identify them and send them in a separate file to translators.

Closes #103660

@Bamieh Bamieh added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Jul 1, 2021
@Bamieh Bamieh requested review from wylieconlon and a team July 1, 2021 09:35
wylieconlon
wylieconlon suggested changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bamieh It looks like you've missed some of the markdown that I've identified, specifically:

  1. Everything in formula/util.ts that is under help or examples

  2. There is a documentation label which is following the pattern lens.indexPattern.XXX.documentation which is all markdown.

...s/lens/public/indexpattern_datasource/operations/definitions/formula/editor/formula_help.tsx Outdated Show resolved Hide resolved
@Bamieh Bamieh requested a review from wylieconlon July 1, 2021 14:12
wylieconlon
wylieconlon approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bamieh
Copy link
Member Author

Bamieh commented Jul 3, 2021

@elasticmachine merge upstream

@Bamieh Bamieh enabled auto-merge (squash) July 3, 2021 15:51
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +151.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Bamieh Bamieh merged commit 7395fee into elastic:master Jul 3, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 3, 2021
@Bamieh @kibanamachine
[Localization] postfix ids with .markdown (elastic#104062)
3822bdc 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Jul 3, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 3, 2021
@Bamieh @kibanamachine
[Localization] postfix ids with .markdown (elastic#104062)
1dbf880 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Jul 3, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 3, 2021
@kibanamachine @Bamieh
[Localization] postfix ids with .markdown (#104062) (#104262)
bd9b3f4 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Ahmad Bamieh <ahmadbamieh@gmail.com>
kibanamachine added a commit that referenced this pull request Jul 3, 2021
@kibanamachine @Bamieh
[Localization] postfix ids with .markdown (#104062) (#104263)
554f157 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Ahmad Bamieh <ahmadbamieh@gmail.com>
@Bamieh Bamieh deleted the i18n/markdown_postfix branch July 4, 2021 09:00
madirey pushed a commit to madirey/kibana that referenced this pull request Jul 6, 2021
@Bamieh @kibanamachine @madirey
[Localization] postfix ids with .markdown (elastic#104062)
c468079 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wylieconlon wylieconlon wylieconlon approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Localization] postfix i18n messages containing markdown with .markdown
3 participants
@Bamieh @kibanamachine @wylieconlon