Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [APM] Link to Fleet APM Server Configuration when managed by Elastic Agent w/Fleet (#100816) #103302

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

…Agent w/Fleet (elastic#100816)

* Register tutorial on APM plugin

* using files from apm

* removing tutorial from apm_oss

* removing export

* fixing i18n

* adding fleet section

* adding fleet information on APM tutorial

* adding fleet typing

* fixing i18n

* adding fleet information on APM tutorial

* checks apm fleet integration when pushing button

* adding fleet information on APM tutorial

* refactoring

* registering status check callback

* addin custom component registration function

* fixing TS issue

* addressing PR comments

* fixing tests

* adding i18n

* fixing issues

* adding unit test

* adding unit test

* addressing PR comments

* fixing TS issue

* moving tutorial to a common directory

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor Author

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1535 1537 +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
home 65 70 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.3MB +4.8KB
home 164.1KB 165.6KB +1.5KB
total +6.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 37.4KB 38.4KB +952.0B
home 15.4KB 16.1KB +726.0B
total +1.6KB
Unknown metric groups

API count

id before after diff
home 89 94 +5

async chunk count

id before after diff
apm 11 13 +2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cauemarcondes

@kibanamachine kibanamachine merged commit 669839c into elastic:7.x Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants