Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Update formula icons #103287

Merged
merged 2 commits into from
Jun 24, 2021
Merged

[Lens] Update formula icons #103287

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75f7817
:lipstick: Updated formula reference icon
dej611 Jun 24, 2021
291a154
:lipstick: Replace wordwrap icons
dej611 Jun 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...s/public/indexpattern_datasource/operations/definitions/formula/editor/formula_editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,6 @@ export function FormulaEditor({
<div className="lnsFormula__editorHeader">
<EuiFlexGroup alignItems="center" gutterSize="m" responsive={false}>
<EuiFlexItem className="lnsFormula__editorHeaderGroup">
{/* TODO: Replace `bolt` with `wordWrap` icon (after latest EUI is deployed) and hook up button to enable/disable word wrapping. */}
<EuiToolTip
content={
isWordWrapped
Expand All @@ -599,7 +598,7 @@ export function FormulaEditor({
position="top"
>
<EuiButtonIcon
iconType="bolt"
iconType={isWordWrapped ? 'wordWrap' : 'wordWrapDisabled'}
display={!isWordWrapped ? 'fill' : undefined}
color={'text'}
aria-label={
Expand Down Expand Up @@ -725,7 +724,7 @@ export function FormulaEditor({
color="text"
onClick={() => setIsHelpOpen(!isHelpOpen)}
>
<EuiIcon type="help" />
<EuiIcon type="documentation" />
<EuiIcon type={isHelpOpen ? 'arrowDown' : 'arrowUp'} />
</EuiLink>
</EuiToolTip>
Expand All @@ -747,7 +746,7 @@ export function FormulaEditor({
<EuiButtonIcon
className="lnsFormula__editorHelp lnsFormula__editorHelp--overlay"
onClick={() => setIsHelpOpen(!isHelpOpen)}
iconType="help"
iconType="documentation"
color="text"
size="s"
aria-label={i18n.translate(
Expand Down