Prevent showing filter on unfilterable fields in data grid #103241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
added
Feature:Discover
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
kertal
approved these changes
Jun 24, 2021
There was a problem hiding this comment.
Code LGTM 👍 , tested locally, works. While testing I noted, that we should improve the following message in the doc viewer table, because it's not telling the truth 😄
Also we should display those buttons in a disabled state in this case, but it's not the scope of this PR.
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 24, 2021
kibanamachine
added a commit
that referenced
this pull request
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #91677
Currently we show the filter button for too many fields, e.g. geo_point fields, which are aggregatable and searchable. We should instead check on the
filterableproperty of the fields (which is also what the legacy doc table does), which will correctly befalsefor geo_point fields.Checklist
Delete any items that are not applicable to this PR.