[Enterprise Search] Convert our full page Loading component to an Enterprise Search logo #103189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- while keeping our component-level LoadingOverlay to a spinner
cee-chen
added
release_note:skip
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 24, 2021
…lastic#103189) - while keeping our component-level LoadingOverlay to a spinner
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that EUI 34.x landed in Kibana, we can use the new
EuiLoadingLogocomponent! P.S. I stole this PR from Scotty because that's the only thing that brings me joy in this world<Loading />to a logo loader<LoadingOverlay />(used mostly in panels / component-level loading) as a spinner - e.g.,<DataPanel isLoading />AS
WS
NOTE: There's a couple places in the gif (Groups table, Source content) that have loading spinners still because they allow filtering content, but I left those alone because a full-page loader doesn't seem right there when filtering content
Checklist