Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Support active nav links that have both subnav & non-subnav child routes #103036

Merged
merged 4 commits into from
Jun 23, 2021
Merged

[Enterprise Search] Support active nav links that have both subnav & non-subnav child routes #103036

merged 4 commits into from
Jun 23, 2021

Commits on Jun 23, 2021

  1. Update generateNavlink to take an items subNav and use it to determ… 

    …ine isSelected

+ change getNavLinkActive to early returns
+ tweak tests for readability
    @cee-chen
    cee-chen committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    84505f8 View commit details
    Browse the repository at this point in the history

  2. Update WS nav Sources link 

    - to show active on creation routes but not on single source routes
    @cee-chen
    cee-chen committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    654e141 View commit details
    Browse the repository at this point in the history

  3. Update AS nav Engines link 

    - should eventually show active on creation routes but not on single engine routes
    @cee-chen
    cee-chen committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    c1dd140 View commit details
    Browse the repository at this point in the history

  4. Update AS engine creation routing 

    - so that it correctly shows as a child route of the Engines link

+ update breadcrumbs
    @cee-chen
    cee-chen committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    31dab28 View commit details
    Browse the repository at this point in the history