Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] Including owner when patching a comment Closes #102732 #103020

Merged
merged 3 commits into from
Jun 24, 2021
Merged

[Cases] Including owner when patching a comment Closes #102732 #103020

merged 3 commits into from
Jun 24, 2021

Conversation

jonathan-buttner
Copy link
Contributor

@jonathan-buttner jonathan-buttner commented Jun 22, 2021 •
edited
Loading

This PR fixes the bug here: #102732 where the owner field wasn't sent down as part of updating a comment causing the edit comment to fail.

Editing comment succeeds

editing comment works

@jonathan-buttner jonathan-buttner added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Feature:Cases Cases feature v7.14.0 Feature:Cases-RAC-RBAC labels Jun 22, 2021
@jonathan-buttner jonathan-buttner marked this pull request as ready for review June 23, 2021 13:45
@jonathan-buttner jonathan-buttner requested a review from a team as a code owner June 23, 2021 13:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 507.5KB 508.0KB +447.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jonathan-buttner jonathan-buttner added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 23, 2021
@jonathan-buttner jonathan-buttner merged commit 9b56549 into elastic:master Jun 24, 2021
@jonathan-buttner jonathan-buttner deleted the fix-update-comment branch June 24, 2021 13:05
@kibanamachine kibanamachine mentioned this pull request Jun 24, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 24, 2021
@jonathan-buttner @kibanamachine
[Cases] Including owner when patching a comment Closes elastic#102732 (…
1bc8cf8 
…elastic#103020)

* Including owner when patching a comment

* Fixing tests
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 24, 2021
@kibanamachine @jonathan-buttner
[Cases] Including owner when patching a comment Closes #102732 (#103020…
fff2251 
…) (#103268)

* Including owner when patching a comment

* Fixing tests

Co-authored-by: Jonathan Buttner <56361221+jonathan-buttner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnasikas cnasikas cnasikas approved these changes

Assignees

@jonathan-buttner jonathan-buttner

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonathan-buttner @elasticmachine @kibanamachine @cnasikas