Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] fix tooltip on annotations with 's are not displayed correctly #102892

Merged
merged 2 commits into from
Jun 23, 2021
Merged

[TSVB] fix tooltip on annotations with 's are not displayed correctly #102892

merged 2 commits into from
Jun 23, 2021

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Jun 22, 2021 •
edited
Loading

Closes: #102631

Summary:

[TSVB] tooltip on annotations with 's are not displayed correctly

Steps to reproduce:

  1. Create a new TSVB viz
  2. Add annotations from kibana_sample_data_ecommerce dataset
  3. Configure it in order to create annotations with the category field
  4. Hover over the annotations and check the tooltip

Screens:
image

@alexwizp alexwizp changed the title [TSVB] tooltip on annotations with 's are not displayed correctly [TSVB] fix tooltip on annotations with 's are not displayed correctly Jun 22, 2021
@alexwizp alexwizp self-assigned this Jun 22, 2021
@alexwizp alexwizp added v7.14.0 v8.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix labels Jun 22, 2021
@alexwizp alexwizp marked this pull request as ready for review June 22, 2021 13:21
@alexwizp alexwizp requested a review from a team June 22, 2021 13:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visTypeTimeseries 500 530 +30

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 986.5KB 979.6KB -7.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

VladLasitsa
VladLasitsa approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@VladLasitsa VladLasitsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally on chrome

stratoula
stratoula approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, it is fixed! Thanx for also converting the files to TS ❤️

@alexwizp alexwizp merged commit 12895d8 into elastic:master Jun 23, 2021
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jun 23, 2021
@alexwizp
[TSVB] fix tooltip on annotations with 's are not displayed correctly (…
f284e9b 
…elastic#102892)

* [TSVB] tooltip on annotations with 's are not displayed correctly

Closes: elastic#102631

* 'handlebars/dist/handlebars' -> 'handlebars'
@alexwizp alexwizp mentioned this pull request Jun 23, 2021
Merged
alexwizp added a commit that referenced this pull request Jun 23, 2021
@alexwizp
[TSVB] fix tooltip on annotations with 's are not displayed correctly (…
6e6cdb0 
…#102892) (#103121)

* [TSVB] tooltip on annotations with 's are not displayed correctly

Closes: #102631

* 'handlebars/dist/handlebars' -> 'handlebars'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladLasitsa VladLasitsa VladLasitsa approved these changes

@stratoula stratoula stratoula approved these changes

Assignees

@alexwizp alexwizp

Labels
Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TSVB] tooltip on annotations with 's are not displayed correctly
5 participants
@alexwizp @elasticmachine @kibanamachine @VladLasitsa @stratoula