Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Functional tests - explicitly delete jobs after setupModule tests #102882

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Jun 22, 2021

Summary

This PR explicitly deletes the jobs created by the setupModule tests.

Details

There were cases where the setupModule tests timed out while waiting for a created job to finish. In some of those cases the cleanMlIndices failed in the suite's after method, causing follow-up issues. With this PR we make sure that the jobs (and corresponding datafeeds) are force-deleted via the ES-API, so nothing is left behind after cleanup phase of the suite.

@pheyos pheyos self-assigned this Jun 22, 2021
@pheyos pheyos requested a review from a team as a code owner June 22, 2021 10:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pheyos

@pheyos pheyos added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 22, 2021
@pheyos pheyos merged commit 0690030 into elastic:master Jun 22, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 22, 2021
elastic#102882)

This PR explicitly deletes the jobs created by the `setupModule` tests.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 22, 2021
elastic#102882)

This PR explicitly deletes the jobs created by the `setupModule` tests.
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.13
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 22, 2021
#102882) (#102912)

This PR explicitly deletes the jobs created by the `setupModule` tests.

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
kibanamachine added a commit that referenced this pull request Jun 22, 2021
#102882) (#102913)

This PR explicitly deletes the jobs created by the `setupModule` tests.

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
@pheyos pheyos deleted the fix_module_test_cleanup branch September 1, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed :ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.13.3 v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants